-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pull-request etiquette #143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @escattone ! Looking mostly good; I've left you a few comments to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good stuff! ...except the unusual spelling with the hypen. :)
@chrisdavidmills I think I've addressed all of your points of feedback. Back to you! |
Thanks for the review @peterbe! I think I've addressed your concerns as well. Back to you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing is that people might be confused as to what to put into the pull request description.
If it's solving an open issue just typing "Fixes #1234" is often all you need to say because the issue itself should describe the problem, so the PR implies the solution.
But I can't think of a great thing to suggest there. Perhaps, "If your pull request isn't referring to a specific issue, please try to mention what problem the pull request is solving."
Co-authored-by: Peter Bengtsson <[email protected]>
Co-authored-by: Peter Bengtsson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@escattone a few more bits, most of them just nits.
Fixes mdn/yari#1098