Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsxref): make $3 a number for all invocations #20146

Merged
merged 1 commit into from
May 27, 2024

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented May 8, 2024

Description

See mdn/content#33490

Unify the last argument ($3 / do not wrap in code tags) of the jsxref macro. This is a preparation to be more strict regarding arguments. I would have opted for a boolean but it seems like the majority of invocations use 1.

@fiji-flo fiji-flo requested review from a team as code owners May 8, 2024 10:39
@fiji-flo fiji-flo requested review from JuanVqz, myshov, sunhpark42, mfuji09, cw118, JasonLamv-t and nathipg and removed request for a team May 8, 2024 10:39
@github-actions github-actions bot added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Preview URLs (39 pages)
Flaws (321)

Note! 9 documents with no flaws that don't need to be listed. 🎉

URL: /fr/docs/Glossary/SIMD
Title: SIMD
Flaw count: 1

  • macros:
    • /fr/docs/Web/JavaScript/Reference/Objets_globaux/SIMD does not exist

URL: /fr/docs/Web/JavaScript/Guide/Meta_programming
Title: Métaprogrammation
Flaw count: 19

  • macros:
    • /fr/docs/Web/JavaScript/Reference/Objets_globaux/Proxy/handler redirects to /fr/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy
    • /fr/docs/Web/JavaScript/Reference/Objets_globaux/Proxy/handler/getPrototypeOf redirects to /fr/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/getPrototypeOf
    • /fr/docs/Web/JavaScript/Reference/Objets_globaux/Proxy/handler/setPrototypeOf redirects to /fr/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/setPrototypeOf
    • /fr/docs/Web/JavaScript/Reference/Objets_globaux/Proxy/handler/isExtensible redirects to /fr/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/isExtensible
    • /fr/docs/Web/JavaScript/Reference/Objets_globaux/Proxy/handler/preventExtensions redirects to /fr/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/preventExtensions
    • and 12 more flaws omitted
  • broken_links:
    • Can't resolve /fr/docs/Web/JavaScript/Reference/Objets_globaux/Proxy/handler
    • Can't resolve /fr/docs/Web/JavaScript/Reference/Opérateurs/L_opérateur_in

URL: /fr/docs/Web/JavaScript/Reference/Global_Objects/Array/every
Title: Array.prototype.every()
Flaw count: 3

  • macros:
    • /fr/docs/Web/JavaScript/Reference/Fonctions/Fonctions_fl%C3%A9ch%C3%A9es redirects to /fr/docs/Web/JavaScript/Reference/Functions/Arrow_functions
  • broken_links:
    • Can't resolve /fr/docs/Web/JavaScript/Reference/Opérateurs/L_opérateur_this
  • translation_differences:
    • Differences in the important macros (2 in common of 4 possible)

URL: /fr/docs/Web/JavaScript/Reference/Operators/function*
Title: Expression function*
Flaw count: 10

  • macros:
    • /fr/docs/Web/JavaScript/Reference/Instructions/function* redirects to /fr/docs/Web/JavaScript/Reference/Statements/function*
    • /fr/docs/Web/JavaScript/Reference/Instructions/function* redirects to /fr/docs/Web/JavaScript/Reference/Statements/function*
    • /fr/docs/Web/JavaScript/Reference/Op%C3%A9rateurs/yield redirects to /fr/docs/Web/JavaScript/Reference/Operators/yield
    • /fr/docs/Web/JavaScript/Reference/Op%C3%A9rateurs/yield* redirects to /fr/docs/Web/JavaScript/Reference/Operators/yield*
    • /fr/docs/Web/JavaScript/Reference/Instructions/function redirects to /fr/docs/Web/JavaScript/Reference/Statements/function
    • and 2 more flaws omitted
  • broken_links:
    • Can't resolve /fr/docs/Web/JavaScript/Reference/Fonctions
    • Can't resolve /fr/docs/Web/JavaScript/Guide/The_Iterator_protocol
  • translation_differences:
    • Differences in the important macros (3 in common of 5 possible)

URL: /es/docs/Web/JavaScript/Guide/Grammar_and_types
Title: Gramática y Tipos
Flaw count: 27

  • macros:
    • /es/docs/Web/JavaScript/Reference/Gramatica_lexica does not exist
    • /es/docs/Web/JavaScript/Reference/Gramatica_lexica does not exist
    • /es/docs/Glossary/Espacio_en_blanco redirects to /es/docs/Glossary/Whitespace
    • /es/docs/Web/JavaScript/Reference/Gramatica_lexica does not exist
    • /es/docs/Web/JavaScript/Reference/Sentencias/var does not exist
    • and 22 more flaws omitted

URL: /es/docs/Web/JavaScript/Guide/Meta_programming
Title: Metaprogramación
Flaw count: 36

  • macros:
    • /es/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler redirects to /es/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy
    • /es/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/getPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/getPrototypeOf
    • /es/docs/Web/JavaScript/Reference/Global_Objects/Reflect/getPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/getPrototypeOf
    • /es/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/setPrototypeOf
    • /es/docs/Web/JavaScript/Reference/Global_Objects/Reflect/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/setPrototypeOf
    • and 28 more flaws omitted
  • broken_links:
    • Can't resolve /es/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler
    • Anchor not lowercase
  • translation_differences:
    • Differences in the important macros (0 in common of 2 possible)

URL: /es/docs/Web/JavaScript/Guide/Iterators_and_generators
Title: Iteradores y generadores
Flaw count: 24

  • macros:
    • /es/docs/Web/JavaScript/Reference/Sentencias/for does not exist
    • /es/docs/Web/JavaScript/Reference/Objetos_globales/Array/map does not exist
    • /es/docs/Web/JavaScript/Reference/Objetos_globales/Array/filter does not exist
    • /es/docs/Web/JavaScript/Reference/Sentencias/for...of does not exist
    • /es/docs/Web/JavaScript/Reference/Sentencias/for...of does not exist
    • and 17 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Can't resolve /es/docs/Web/JavaScript/Herencia_y_la_cadena_de_protipos

URL: /ko/docs/Web/JavaScript/Guide/Iterators_and_generators
Title: 반복기 및 생성기
Flaw count: 3

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Operators/Spread_operator redirects to /ko/docs/Web/JavaScript/Reference/Operators/Spread_syntax
  • broken_links:
    • Anchor not lowercase
    • Can't resolve /ko/docs/Web/JavaScript/Guide/Inheritance_and_the_prototype_chain

URL: /ko/docs/Web/JavaScript/Reference/Classes
Title: Classes
Flaw count: 7

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Classes/Public_class_fields does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields
    • /ko/docs/Web/JavaScript/Reference/Classes/Private_class_fields redirects to /ko/docs/Web/JavaScript/Reference/Classes/Private_properties
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Object/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/setPrototypeOf
    • /ko/docs/Web/JavaScript/Reference/Global_Objects/Symbol/species does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/species
    • /ko/docs/Web/JavaScript/Reference/Classes/Public_class_fields does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields
    • and 1 more flaws omitted
  • broken_links:
    • Can't resolve https://developer.mozilla.org/ko/docs/Web/JavaScript/Introduction_to_Object-Oriented_JavaScript#The_object_(class_instance)

URL: /ko/docs/Web/JavaScript/Reference/Operators/Operator_precedence
Title: 연산자 우선순위
Flaw count: 5

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Operators/delete does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/delete
  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_operator
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/Conditional_Operator
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/Assignment_Operators
    • Can't resolve /ko/docs/Web/JavaScript/Reference/Operators/Comma_Operator

URL: /ko/docs/Web/JavaScript/Reference/Statements
Title: 문 및 선언
Flaw count: 7

  • macros:
    • /ko/docs/Web/JavaScript/Reference/Statements/switch does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Statements/switch
    • /ko/docs/Web/JavaScript/Reference/Statements/try...catch does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Statements/try...catch
    • /ko/docs/Web/JavaScript/Reference/Statements/for_each...in does not exist
    • /ko/docs/Web/JavaScript/Reference/Statements/with does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Statements/with
  • broken_links:
    • Can't resolve /ko/docs/Web/JavaScript/Guide/The_Iterator_protocol
    • Can't resolve /ko/docs/Web/JavaScript/Guide/Iterators_and_Generators
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /zh-CN/docs/Glossary/Boolean/JavaScript
Title: 布尔值(JavaScript)
Flaw count: 1

  • macros:
    • /zh-CN/docs/Glossary/wrapper does not exist but fell back to /en-US/docs/Glossary/Wrapper

URL: /zh-CN/docs/Web/API/CookieChangeEvent/changed
Title: CookieChangeEvent:changed 属性
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/CookieChangeEvent does not exist but fell back to /en-US/docs/Web/API/CookieChangeEvent

URL: /zh-CN/docs/Web/API/CookieChangeEvent/deleted
Title: CookieChangeEvent:deleted 属性
Flaw count: 1

  • macros:
    • /zh-CN/docs/Web/API/CookieChangeEvent does not exist but fell back to /en-US/docs/Web/API/CookieChangeEvent

URL: /zh-CN/docs/Web/JavaScript/Reference
Title: JavaScript 参考
Flaw count: 4

  • macros:
    • /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/BigUint64Array does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/BigUint64Array
    • /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/FinalizationRegistry
    • /zh-CN/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat
    • /zh-CN/docs/Web/JavaScript/Reference/Operators/import does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/import

URL: /ja/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers
Flaw count: 12

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /ja/Add-ons/WebExtensions
    • /ja/Add-ons/Themes does not exist
    • /ja/docs/Web/JavaScript/Reference/Global_Objects/RelativeTimeFormat does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/RelativeTimeFormat
    • /ja/docs/Web/API/SVGImageElement does not exist but fell back to /en-US/docs/Web/API/SVGImageElement
    • /ja/docs/Web/API/SharedWorkerGlobalScope/onconnect does not exist but fell back to /en-US/docs/Web/API/SharedWorkerGlobalScope/connect_event
    • and 6 more flaws omitted
  • broken_links:
    • Can't resolve /ja/docs/Glossary/webp

URL: /ja/docs/Web/API/XMLHttpRequest_API
Title: XMLHttpRequest API
Flaw count: 2

  • macros:
    • `/home/runner/work/translated-content/translated-content/mdn/content/node_modules/@mdn/yari/kumascript/macros/AvailableInWorkers.ejs:1

1| <%
2| // Inserts a notecards about this feature being available in Web Workers.
3| //
4| // Parameters:

'notservice' is not a recognized argument to this macro`

  • translation_differences:
    • Differences in the important macros (4 in common of 6 possible)

URL: /ja/docs/Web/JavaScript/Guide/Working_with_objects
Title: オブジェクトでの作業
Flaw count: 10

  • broken_links:
    • Can't resolve /ja/docs/Web/JavaScript/Guide/Details_of_the_Object_Model
    • Can't resolve /ja/docs/Web/JavaScript/Reference/Operators/Property_Accessors
    • Can't resolve /ja/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_5_support_in_Mozilla
    • Anchor not lowercase
    • Can't resolve /ja/docs/Web/JavaScript/Guide/Inheritance_and_the_prototype_chain
    • and 5 more flaws omitted

URL: /ja/docs/Web/JavaScript/Guide/Functions
Title: 関数
Flaw count: 1

  • macros:
    • /ja/docs/Web/JavaScript/Reference/Global_Objects/uneval redirects to /ja/docs/Web/JavaScript/Reference/Global_Objects

URL: /ja/docs/Web/JavaScript/Guide/Meta_programming
Title: メタプログラミング
Flaw count: 2

  • macros:
    • /ja/docs/Web/JavaScript/Reference/Global_Objects/Proxy/enumerate does not exist
    • /ja/docs/Web/JavaScript/Reference/Reflect/enumerate does not exist

URL: /ja/docs/Web/JavaScript/Guide/Iterators_and_generators
Title: イテレーターとジェネレーター
Flaw count: 1

  • broken_links:
    • Anchor not lowercase

URL: /ja/docs/Web/JavaScript/Guide/Keyed_collections
Title: キー付きコレクション
Flaw count: 2

  • broken_links:
    • Is currently http:// but can become https://
    • Can't resolve /ja/docs/Web/JavaScript/Reference/Operators/Spread_operator

URL: /pt-BR/docs/Web/JavaScript/Guide/Meta_programming
Title: Meta programação
Flaw count: 30

  • macros:
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/getPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/getPrototypeOf
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Reflect/getPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/getPrototypeOf
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/setPrototypeOf
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Reflect/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/setPrototypeOf
    • and 23 more flaws omitted
  • broken_links:
    • Can't resolve /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler
    • Anchor not lowercase

URL: /pt-BR/docs/Web/JavaScript/Guide/Iterators_and_generators
Title: Iteratores e geradores
Flaw count: 6

  • macros:
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/TypedArray does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray
    • /pt-BR/docs/Web/JavaScript/Reference/Operators/Spread_operator does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Generator/next does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator/next
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Generator/throw does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator/throw
    • /pt-BR/docs/Web/JavaScript/Reference/Global_Objects/Generator/return does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator/return
  • broken_links:
    • Can't resolve /pt-BR/docs/Web/JavaScript/Guide/Inheritance_and_the_prototype_chain

URL: /zh-TW/docs/Web/JavaScript/Reference/Classes
Title: Classes
Flaw count: 6

  • macros:
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/ReferenceError does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/ReferenceError
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/SyntaxError does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/SyntaxError
    • /zh-TW/docs/Web/JavaScript/Reference/Classes/Public_class_fields does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Classes/Public_class_fields
    • /zh-TW/docs/Web/JavaScript/Reference/Classes/Private_properties does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Classes/Private_properties
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/Object/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/setPrototypeOf
    • and 1 more flaws omitted

URL: /ru/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 для разработчиков
Flaw count: 47

  • macros:
    • /ru/docs/Mozilla/Firefox/Experimental_features does not exist but fell back to /en-US/docs/Mozilla/Firefox/Experimental_features
    • Wrong xref macro used (consider changing which macro you use). Error processing path /ru/Add-ons/WebExtensions
    • /ru/Add-ons/Themes does not exist
    • /ru/docs/Web/HTML/Element/textarea does not exist but fell back to /en-US/docs/Web/HTML/Element/textarea
    • /ru/docs/Web/HTML/Element/iframe does not exist but fell back to /en-US/docs/Web/HTML/Element/iframe
    • and 33 more flaws omitted
  • broken_links:
    • Can't resolve /ru/docs/Tools/Page_Inspector/How_to/Examine_Flexbox_layouts
    • Can't resolve /ru/docs/Tools/Debugger
    • Can't resolve /ru/docs/Tools/Accessibility_inspector#Вывод_дерева_доступности_в_JSON-формате
    • Can't resolve /ru/docs/Tools/Инспектор_доступности#Цветовой_контраст
    • Can't resolve /ru/docs/Tools/Network_Monitor
    • and 4 more flaws omitted

URL: /ru/docs/Web/API/Document/cookie
Title: Document.cookie
Flaw count: 19

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/null redirects to /ru/docs/Web/JavaScript/Reference/Operators/null
  • broken_links:
    • Can't resolve /ru/docs/Web/API/Document/cookie/Simple_document.cookie_framework
    • No need for the pathname in anchor links if it's the same page
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 12 more flaws omitted
  • translation_differences:
    • Differences in the important macros (3 in common of 13 possible)

URL: /ru/docs/Web/JavaScript/Guide/Meta_programming
Title: Мета-программирование
Flaw count: 27

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/getPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/getPrototypeOf
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Reflect/getPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/getPrototypeOf
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/Proxy/setPrototypeOf
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Reflect/setPrototypeOf does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Reflect/setPrototypeOf
    • and 20 more flaws omitted
  • broken_links:
    • Can't resolve /ru/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler
    • Anchor not lowercase

URL: /ru/docs/Web/JavaScript/Guide/Iterators_and_generators
Title: Итераторы и генераторы
Flaw count: 6

  • macros:
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Map does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map
    • /ru/docs/Web/JavaScript/Reference/Global_Objects/Map does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Map
  • broken_links:
    • Can't resolve /ru/docs/Web/JavaScript/Reference/Operators/Array_comprehensions
    • Can't resolve /ru/docs/Web/JavaScript/Reference/Operators/Generator_comprehensions
    • Can't resolve /ru/docs/Web/JavaScript/Guide/Inheritance_and_the_prototype_chain
    • Can't resolve /ru/docs/Web/JavaScript/Reference/Operators/Spread_operator

URL: /ru/docs/Web/JavaScript/Reference/Operators/class
Title: class expression
Flaw count: 1

  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)
External URLs (2)

URL: /ja/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers


URL: /ru/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 для разработчиков

@yin1999 yin1999 added the needs content update Needs update to the content to support this change. label May 8, 2024
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a +1, thanks!

@leon-win
Copy link
Member

leon-win commented May 8, 2024

Good for ru, thank you @fiji-flo ! 👍

@leon-win leon-win removed the request for review from myshov May 8, 2024 13:22
Copy link
Collaborator

@mfuji09 mfuji09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ja contents.

Copy link
Member

@JuanVqz JuanVqz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for ES cc @Graywolf9, Thank you! :shipit:

Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the l10n-zh content. Thank you @fiji-flo

Copy link
Member

@SphinxKnight SphinxKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fiji-flo, LGTM for fr

@yin1999 yin1999 removed the request for review from cw118 May 13, 2024 08:38
@yin1999 yin1999 removed the needs content update Needs update to the content to support this change. label May 14, 2024
Copy link
Contributor

@sunhpark42 sunhpark42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ko contents. thank you @fiji-flo :)

Copy link
Collaborator

@josielrocha josielrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve for pt-BR 👍🏼

@yin1999
Copy link
Member

yin1999 commented May 27, 2024

Approved by all localization teams. I'm going to merge this. Thank you @fiji-flo

@yin1999 yin1999 merged commit 90d67fd into mdn:main May 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n-es Issues related to Spanish content. l10n-fr Issues related to French content. l10n-ja Issues related to Japanese content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content. l10n-zh Issues related to Chinese content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants