Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsxref): make $3 a number for all invocations #33490

Merged
merged 1 commit into from
May 13, 2024

Conversation

fiji-flo
Copy link
Contributor

@fiji-flo fiji-flo commented May 8, 2024

Description

Unify the last argument ($3 / do not wrap in code tags) of the jsxref macro. This is a preparation to be more strict regarding arguments. I would have opted for a boolean but it seems like the majority of invocations use 1.

@fiji-flo fiji-flo requested review from a team as code owners May 8, 2024 10:38
@fiji-flo fiji-flo requested review from Elchi3 and removed request for a team May 8, 2024 10:38
@github-actions github-actions bot added Content:WebAPI Web API docs Content:JS JavaScript docs Content:Firefox Content in the Mozilla/Firefox subtree size/s [PR only] 6-50 LoC changed labels May 8, 2024
Copy link
Contributor

github-actions bot commented May 8, 2024

Preview URLs (7 pages)
Flaws (2)

Note! 6 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers
Flaw count: 2

  • macros:
    • Wrong xref macro used (consider changing which macro you use). Error processing path /en-US/Add-ons/WebExtensions
    • /en-US/Add-ons/Themes does not exist
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/65
Title: Firefox 65 for developers

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yin1999
Copy link
Member

yin1999 commented May 9, 2024

For another macro {{domxref}}, it seems that there are more macro calls using the argument "nocode". IMO, we should use the same argument for both macros representing the <code> wrapper should not be added.

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@fiji-flo
Copy link
Contributor Author

fiji-flo commented May 9, 2024

@yin1999 I'll do this for all macros in the next few weeks.

@fiji-flo fiji-flo merged commit 2d337c3 into mdn:main May 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Firefox Content in the Mozilla/Firefox subtree Content:JS JavaScript docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants