-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with "HTMLIFrameElement": … #328
Comments
This is an interesting one. Most HTML attributes don't have their own separate page, so we shouldn't be turning them into links in the BCD tables. @ddbeck , is this what we did historically for the old tables on the previous platform? @peterbe also tapping you to see if we could get a quick fix here. |
The underlying BCD featuers have This is also how the wiki worked. On the wiki, however, broken links had a different color to indicate their brokenness. The new site doesn't do that, which makes this sting a bit more. We've considered removing non-existent mdn_urls from BCD, but it's been neglected because it was never broken enough to matter. Narrowly, you can fix this by removing the MDN URLs from the underlying BCD features. Or we could put some effort into coming up with a better approach to MDN URLs in BCD overall. |
This might be related by #1712 and mdn/yari#2065 by now. |
@chrisdavidmills, @ddbeck I've stumbled upon this while working on 10423 for #4309 and the subfeatures have a MDN URL in BCD despite the pages not being created. |
@mirunacurtean this is an issue with different types of broken links behaving differently. Once all links behave the same (see mdn/yari#3799), this should mitigate the problem somewhat. If this is the case (it is clearly indicated when a link is broken because the page just doesn't exist), then I don't think it is worth removing the links. |
The broken links now all show red and mdn/yari#3799 is closed. This may no longer be an issue. |
Closing per #328 (comment), as the links to pages which don’t exist yet are now clearly distinguished and easily identifiable. The problem of pages having some links to other non-existing-yet pages is a general problem that’s not exclusive to the https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement page — and I don’t think we want to raise an open issue for every single page that has such links on it. So I’m going ahead and closing this one. |
MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement
What information was incorrect, unhelpful, or incomplete?
Many of the links are broken
Specific section or headline?
Browser Compatibility Page
What did you expect to see?
Not a broken link
Did you test this? If so, how?
Clicked on the height link in the table
MDN Content page report details
en-us/web/api/htmliframeelement
The text was updated successfully, but these errors were encountered: