Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify PerformanceEventTiming table to show it is enabled on FF 89 #10423

Merged
merged 5 commits into from
May 19, 2021
Merged

Modify PerformanceEventTiming table to show it is enabled on FF 89 #10423

merged 5 commits into from
May 19, 2021

Conversation

mirunacurtean
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes

  • removed experimental status

  • Updated FF and FF for Android columns to show that feature has been enabled in 89th version.

  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)

We have PerformanceEventTiming enabled in Nightly for over a month now...

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 10, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented May 12, 2021

Hey @mirunacurtean, you've updated the main interface here, but none of its members. Is that right? Or is there additional work to be done on the subfeatures here?

@mirunacurtean
Copy link
Contributor Author

Hey @mirunacurtean, you've updated the main interface here, but none of its members. Is that right? Or is there additional work to be done on the subfeatures here?

@ddbeck Yes, I think so; if you're referring to only the PerformanceEventTiming being affected by these changes and yes it was only what was in the UI that should've been modified. If I misunderstand something, we can chat over it on slack.

@mirunacurtean
Copy link
Contributor Author

@ddbeck This is now ready for another review. I've updated all the other subfeature rows and deleted the yarn file.
So that the consistency is maintained I've also added an MDN URL to the .target attribute, even if there is no page created for it yet.

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @mirunacurtean. Thank you! 🎉

@ddbeck ddbeck merged commit 2575376 into mdn:main May 19, 2021
@mirunacurtean mirunacurtean deleted the modify-performance-timing-event-table branch May 19, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WebAPI] Enable PerformanceEventTiming
2 participants