Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Page not yet created' links do not reflect that #2065

Closed
mirunacurtean opened this issue Dec 10, 2020 · 5 comments · Fixed by #2527
Closed

'Page not yet created' links do not reflect that #2065

mirunacurtean opened this issue Dec 10, 2020 · 5 comments · Fixed by #2527
Labels
🐛 bug Something isn't working, or isn't working as expected p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Milestone

Comments

@mirunacurtean
Copy link

Steps to reproduce:

  1. Go to https://developer.allizom.org/en-US/docs/Web/JavaScript/Reference/Global_Objects#Control_abstraction_objects.
  2. View all code examples.
  3. Hover over the AsyncGenerator and AsyncGeneratorFunction links and see that pages for this have not yet been created.

Actual results:
Unwritten pages links are indistunguashable from written ones.
image

Expected result:
Visual warning through red colour that pages have not been written yet.
image

@ghost
Copy link

ghost commented Dec 10, 2020

I don't know how this is handled in Kuma but it seems like a smart way to handle it not to set href and then use an attribute selector for the style.

@peterbe
Copy link
Contributor

peterbe commented Dec 11, 2020

This what I call pre-launch regression. We had it working recently but it seems to have gone away.
As you can see, the HTML is correct.

<a class="new" 
  title="The documentation about this has not yet been written; please consider contributing!" 
 data-flaw-src="{{JSxRef(&quot;Global_Objects/AsyncGenerator&quot;, &quot;AsyncGenerator&quot;)}}">  <code>AsyncGenerator</code>
</a>

@schalkneethling we used to have a a.new style, but perhaps that was back in the "kumastyles" day.
If we can't fix this rapidly before the launch, I think we should try to prioritize it for early next week.
In my view, we just need some color on those links that make them look less like a clickable link.

@ghost
Copy link

ghost commented Dec 11, 2020

I finally found a reason to use a:link 🧐 So it would appear to

  • a -> red
  • a:link -> blue.

https://css-tricks.com/how-to-disable-links/

SEO should be happy this way too.

For Sass - mdn/minimalist

@schalkneethling
In the CSS trick article "lazily" even the same rules of the :visited are put together but in Sass I would abound with braces.

a {
 color: red;
 :link {
  color: blue;
  }
 :visited {
  color: MediumSeaGreen 🤷🏻‍♂️
  }
}

For React

TBD

@peterbe
Copy link
Contributor

peterbe commented Dec 11, 2020

I quite like their idea about cursor: not-allowed;

@schalkneethling schalkneethling added 🐛 bug Something isn't working, or isn't working as expected p1 We will address this soon and will provide capacity from our team for it in the next few releases. labels Jan 11, 2021
@schalkneethling schalkneethling added this to the Matcha milestone Jan 13, 2021
escattone pushed a commit that referenced this issue Jan 14, 2021
* fix: add style for links to pages that do not yet exists

Change the class name used for link to page that do not yet exists from `new` to `page-not-created` and add relevant styling.

fix #2065

* fix failing tests

* add support for new class name
@ghost
Copy link

ghost commented Jan 15, 2021

Screenshot_20210115-192117.png

Nice orange 🍊🙂👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working, or isn't working as expected p1 We will address this soon and will provide capacity from our team for it in the next few releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants