Closed
Conversation
github-actions
bot
added
the
data:api
8 tasks
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
github-actions
bot
added
the
merge conflicts 🚧
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Contributor
Author
|
Closing. This has been superseded by #26885 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://bugzilla.mozilla.org/show_bug.cgi?id=1225110#c33
Notification.maxActionsstatic property is nightly only, not release as indicated by #26371Note that I fixed up the
Notification.actionsin #26450 but it wasn't obvious to me that this particular item was behind a pref (i.e. I thought the developers had made a mistake).Related docs work can be tracked in mdn/content#38886
EDIT Actually, this was omitted and current value correct.. This may need to change, but is waiting on https://bugzilla.mozilla.org/show_bug.cgi?id=1963263