Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
hamishwillee
commented
May 23, 2025
| }, | ||
| "status": { | ||
| "experimental": false, | ||
| "experimental": true, |
Contributor
Author
There was a problem hiding this comment.
Since now only one browser implementation live
8 tasks
Notification.maxactions_static behind pref (enabled in Nightly)
caugner
approved these changes
May 23, 2025
| }, | ||
| { | ||
| "version_added": "138", | ||
| "version_removed": "140" |
Contributor
There was a problem hiding this comment.
Nit: We could have added a note to explain it, although we usually only do it in combination with partial_implementation.
Suggested change
| "version_removed": "140" | |
| "version_removed": "140", | |
| "notes": "Accidental early exposure (see [bug 1963263](https://bugzil.la/1963263))." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FF140 puts
Notification.maxActionsbehind the prefdom.webnotifications.actions.enabledwhich is enabled in nightly, along withNotification.actions) in https://bugzilla.mozilla.org/show_bug.cgi?id=1963263The effect on desktop is simple -
maxActionswas published, but is now enabled in preview.actionsstays the same - in preview.The bug also changes the pref to false in android.
I tried to indicate this but the tools stripped it out.
It looks to me like the current docs indicate that if I have a nightly version of FF on my phone it should work (?) - but that is not the case. I guess this is right?
Related docs work can be tracked in mdn/content#39620