Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kunnen zien van welke zaken na beoordeling uitzondering van vernietiging niet is overgenomen #498

Closed
7 of 9 tasks
svenvandescheur opened this issue Nov 19, 2024 · 2 comments · Fixed by #513, #514 or #523
Closed
7 of 9 tasks
Assignees

Comments

@svenvandescheur
Copy link
Contributor

svenvandescheur commented Nov 19, 2024

https://dimpact.atlassian.net/jira/software/c/projects/PZ/boards/258?selectedIssue=PZ-4335

Als <Beoordelaar/reviewer>
Wil ik <in de lijst die ik van de records manager terugkrijg als reactie op mijn beoordeling, kunnen zien welke zaken waarvan ik uitzondering van vernietiging heb gevraagd, door de records manager niet van vernietiging zijn uitgezonderd>
Zodat

Acceptatie criteria:

  • (Door de recordmanager geweigerde) Uitgezonderde zaken staan by default bovenaan
    • Het moet duidelijk zijn dat deze zaken open staat voor (her)beoordeling; bijv. door het vakje ‘niet beoordeeld’ leeg te laten
  • De reeds goedgekeurde zaken blijven op goedgekeurd staan in de lijst.
    • Markering van de niet uitgezonderde zaken door kleur of symbool
  • Mogelijkheid om zaken alsnog goed of af te keuren

Todo

Backend

  • Modify the DestructionListItemReadSerializer to have a field review_advice_ignored.
  • Change the ordering of the items so that the items with ignored advice are at the top. [#498] Add field to Destruction list item serialiser #513
  • When a review response is processed, create the Selection in the backend with selected=True/false. The items where the recordmanager ignored a suggestion from the reviewer should have "selected=False".
  • Add comment that the key for the selection needs to remain in sync between the backend and the frontend.
  • Add a comment/docs that a selection is deleted once a review is submitted. [#498] Pre populate selection after processing review response #514
  • E2E test

Frontend

  • Implement retrieval of the prepopulated selection on page load.
  • Update Destructio list review page to use destructio list endpoint instead of zaken endpoint
  • Use the new field added in the backend
@svenvandescheur svenvandescheur converted this from a draft issue Nov 19, 2024
SilviaAmAm added a commit that referenced this issue Nov 21, 2024
SilviaAmAm added a commit that referenced this issue Nov 21, 2024
SilviaAmAm added a commit that referenced this issue Nov 21, 2024
SilviaAmAm added a commit that referenced this issue Nov 22, 2024
This is needed so that the frontend can retrieve the prepopulated selection and immediately show to the reviewer which zaken need attention
SilviaAmAm added a commit that referenced this issue Nov 22, 2024
…d-zaken

[#498] Add field to Destruction list item serialiser
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Archiefbeheer - Sprints Nov 22, 2024
SilviaAmAm added a commit that referenced this issue Nov 22, 2024
This is needed so that the frontend can retrieve the prepopulated selection and immediately show to the reviewer which zaken need attention
@SilviaAmAm
Copy link
Collaborator

Still frontend and E2E tests to do

@SilviaAmAm SilviaAmAm reopened this Nov 22, 2024
@SilviaAmAm SilviaAmAm moved this from Done to In Progress in Open Archiefbeheer - Sprints Nov 22, 2024
@SilviaAmAm SilviaAmAm removed their assignment Nov 22, 2024
Xaohs pushed a commit that referenced this issue Nov 22, 2024
Xaohs pushed a commit that referenced this issue Nov 22, 2024
Xaohs pushed a commit that referenced this issue Nov 22, 2024
Xaohs pushed a commit that referenced this issue Nov 22, 2024
SilviaAmAm added a commit that referenced this issue Nov 22, 2024
…ection

[#498] Pre populate selection after processing review response
@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Archiefbeheer - Sprints Nov 22, 2024
@SilviaAmAm SilviaAmAm reopened this Nov 22, 2024
@SilviaAmAm SilviaAmAm moved this from Done to In Progress in Open Archiefbeheer - Sprints Nov 22, 2024
@svenvandescheur
Copy link
Contributor Author

Does not require maykinmedia/admin-ui#155

@svenvandescheur svenvandescheur moved this from In Progress to Has Pull Request in Open Archiefbeheer - Sprints Dec 3, 2024
Xaohs added a commit that referenced this issue Dec 3, 2024
@Xaohs Xaohs closed this as completed in #523 Dec 3, 2024
@github-project-automation github-project-automation bot moved this from Has Pull Request to Done in Open Archiefbeheer - Sprints Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment