♻️ [#498] Move ordering to filterset

backend/src/openarchiefbeheer/destruction/api/filtersets.py

@@ -1,4 +1,4 @@
-from django.db.models import Case, QuerySet, Value, When
+from django.db.models import Case, F, QuerySet, Value, When
 from django.utils.translation import gettext_lazy as _
 
 from django_filters import (
@@ -41,6 +41,13 @@ class DestructionListItemFilterset(FilterSet):
             "to define the exact same ordering as the zaak endpoint"
         ),
     )
+    order_review_ignored = BooleanFilter(
+        field_name="ordering",
+        method="filter_order_review_ignored",
+        help_text=_(
+            "Return the items where a record manager went against the advice of a reviewer first."
+        ),
+    )
 
     class Meta:
         model = DestructionListItem
@@ -49,6 +56,7 @@ class Meta:
             "status",
             "processing_status",
             "order_match_zaken",
+            "order_review_ignored",
         )
 
     def filter_in_destruction_list(
@@ -77,6 +85,11 @@ def filter_order_match_zaken(
     ) -> QuerySet[DestructionListItem]:
         return queryset.order_by("zaak__pk")
 
+    def filter_order_review_ignored(
+        self, queryset: QuerySet[DestructionListItem], name: str, value: bool
+    ) -> QuerySet[DestructionListItem]:
+        return queryset.order_by(F("review_advice_ignored").desc(nulls_last=True))
+
 
 class DestructionListFilterset(FilterSet):
     assignee = NumberFilter(

backend/src/openarchiefbeheer/destruction/api/viewsets.py

@@ -2,16 +2,7 @@
 
 from django.contrib.contenttypes.models import ContentType
 from django.db import transaction
-from django.db.models import (
-    Case,
-    F,
-    OuterRef,
-    Prefetch,
-    QuerySet,
-    Subquery,
-    Value,
-    When,
-)
+from django.db.models import Case, OuterRef, Prefetch, QuerySet, Subquery, Value, When
 from django.shortcuts import get_object_or_404
 from django.utils.translation import gettext_lazy as _
 
@@ -445,7 +436,7 @@ def get_queryset(self):
                 )
             )
         )
-        return qs.order_by(F("review_advice_ignored").desc(nulls_last=True))
+        return qs
 
 
 @extend_schema_view(