🎨 - refactor: refactored the attributetable #155
+117
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d a compact mode reflecting the original behaviour
|
Can you make sure the divider is on top of all rows and also at the bottom of the last? Also can you try see if a CSS border-block-start can be used instead of the HR? |
svenvandescheur
requested changes
Dec 3, 2024
|
Some PR feedback, also: the UI tests show that the text labels are off-center... |
|
I applied the PR feedback- the labels not being centered stemmed from gaps in the grid. Should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes maykinmedia/open-archiefbeheer#499
compactprop to reflect the original component's behaviorNote: current implementations of this component would require the
compactprop to retain their original functionality