feat: add support for separate metrics tab independent of traces for OTEL

[roroghost17]

Summary

Adds a traces_enabled flag to OTel profiles, allowing a profile to operate in a metrics-only mode without requiring a collector_url. Previously, every enabled profile required a collector URL because traces were always on. This change decouples trace and metrics export so each can be independently toggled.

Changes

• Added traces_enabled boolean field to Profile with a default of true so existing configs continue exporting spans without modification.
• collector_url is now only required when traces_enabled is true; a metrics-only profile (traces_enabled: false, metrics_enabled: true) no longer needs one.
• The trace client is only built when traces_enabled is true; Inject already skips a nil client.
• Protocol validation is skipped entirely when both traces and metrics are disabled (no-op profile).
• The JSON schema's collector_url requirement condition was updated to account for traces_enabled: false, and protocol was added to the metrics_enabled requirement.
• The profileForStorage struct and MarshalForStorage now persist traces_enabled so the flag survives storage round-trips.
• The OTel profile form in the UI was reorganized into Traces and Metrics tabs. Trace-specific fields (collector URL, format, export timeout, request headers, content logging toggles) are nested under the Traces tab and hidden when traces_enabled is off. The Protocol selector was promoted to a shared connection setting above the tabs since both exporters use it.
• Tab headers show a destructive badge when the tab contains a validation error, and the profile header shows a "Metrics only" badge when traces are disabled but metrics are enabled.
• The E2E helper for enabling metrics export now clicks the Metrics tab before interacting with the toggle, since it is no longer the default active tab.
• Added unit tests covering: default TracesEnabled behavior, metrics-only profile initialization, traces-enabled profile requiring collector_url, both-disabled no-op profile, and storage round-trip fidelity.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

# Plugin unit tests
go test ./plugins/otel/...

# UI
cd ui
pnpm i
pnpm build

Metrics-only profile config example:

{
  "profiles": [
    {
      "traces_enabled": false,
      "protocol": "http",
      "metrics_enabled": true,
      "metrics_endpoint": "otel-collector:4318"
    }
  ]
}

Expected: profile initializes without error, no trace client is built, metrics exporter is active.

Existing traces-only config (no traces_enabled field): should continue to work unchanged, defaulting traces_enabled to true.

Breaking changes

• Yes
• No

Existing configs omitting traces_enabled default to true and behave identically to before.

Security considerations

No new secrets or auth surfaces introduced. The collector_url secret var handling is unchanged; it is simply no longer required when traces are disabled.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• New Features
  • OpenTelemetry profiles can independently enable traces and metrics.
  • Added dedicated Traces and Metrics tabs with feature-specific controls and validation.
  • Added support for metrics-only, traces-only, or fully disabled profiles.
  • Added a “Metrics only” profile indicator.
• Bug Fixes
  • Trace settings and collector requirements no longer block metrics-only profiles.
  • Existing profiles continue to enable tracing by default.
  • Metrics export configuration now correctly selects the Metrics tab.
  • Metrics configurations now validate required endpoints and protocols.

Walkthrough

OTEL profiles now support independent trace and metrics export. Trace settings persist with profiles, runtime initialization supports metrics-only and disabled profiles, schemas apply conditional validation, and the UI separates trace and metrics controls into tabs.

Changes

Independent OTEL export

Layer / File(s)	Summary
Profile contracts and conditional validation plugins/otel/main.go, transports/config.schema.json, ui/lib/types/schemas.ts	Profiles add traces_enabled, default it to true, persist it, and validate trace and metrics settings independently.
Conditional target initialization plugins/otel/main.go, plugins/otel/profiles_test.go	Trace clients are created only when tracing is enabled. Metrics-only and fully disabled profiles initialize without trace clients. Tests cover defaults, validation, initialization, and storage round-tripping.
Tabbed observability configuration ui/app/workspace/observability/fragments/otelFormFragment.tsx, tests/e2e/features/observability/pages/observability.page.ts	The form separates trace and metrics settings into tabs, shows per-tab validation, supports metrics-only profiles, and updates metrics-toggle automation.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Operator
  participant OtelFormFragment
  participant OtelConfigSchema
  participant ProfileTarget
  participant Exporters
  Operator->>OtelFormFragment: configure trace and metrics toggles
  OtelFormFragment->>OtelConfigSchema: validate profile settings
  OtelConfigSchema->>ProfileTarget: provide validated configuration
  ProfileTarget->>Exporters: create enabled trace and metrics exporters

Loading

Possibly related PRs

• maximhq/bifrost#5941: Updates Helm chart configuration for the same traces_enabled and conditional OTEL validation.
• maximhq/bifrost#5942: Documents the metrics-only OTEL configuration implemented here.

Suggested reviewers: bearts, akshaydeo

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the main change: independent metrics support in the OpenTelemetry profile UI and configuration.
Description check	✅ Passed	The description covers the required sections, explains the design, lists tests, and documents compatibility; UI screenshots are not included.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 08-06-feat_add_support_for_separate_metrics_tab_independent_of_traces_for_otel

---

_{Comment @coderabbitai help to get the list of available commands.}

[CLAassistant]

All committers have signed the CLA.

[roroghost17]

• docs: add OTEL trace / metrics headers doc and fixes the pushed metrics list #5942
• chore: update helm-charts for OTEL trace / metrics headers changes #5941
• feat: add separate headers support for traces and metrics in OTEL collector #5940
• feat: add support for separate metrics tab independent of traces for OTEL #5939 👈 (View in Graphite)
• chore: doc fixes for config.schema.json #5938
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

plugins/otel/main.go (1)

593-599: 🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win

Guard target.client before Close() in the push-interval branch.

A metrics-only profile leaves target.client as nil. If metrics_push_interval exceeds 300, line 597 calls target.client.Close() without a nil check and panics. The neighbouring branches at lines 588 and 612 already guard this case.

🐛 Proposed fix

 		} else if pushInterval > 300 {
-			target.client.Close()
+			if target.client != nil {
+				target.client.Close()
+			}
 			return nil, fmt.Errorf("profile %d: metrics_push_interval must be between 1 and 300 seconds, got %d", index, pushInterval)
 		}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/otel/main.go` around lines 593 - 599, Guard target.client before
calling Close() in the pushInterval > 300 validation branch, matching the
nil-safe handling in the neighboring branches. Preserve the existing error
return for invalid metrics_push_interval values while preventing a panic for
metrics-only profiles.

🧹 Nitpick comments (1)

plugins/otel/profiles_test.go (1)

380-405: 🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Add coverage for a metrics-only profile with an out-of-range push interval.

TestInitMetricsOnlyProfile proves target.client stays nil. No test drives the metrics_push_interval > 300 branch in buildTarget, which dereferences target.client without a nil check. A test with {"traces_enabled": false, "protocol": "http", "metrics_enabled": true, "metrics_endpoint": "localhost:4318", "metrics_push_interval": 301} would fail today. See the related comment on plugins/otel/main.go lines 593-599.

Also applies to: 423-446

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@plugins/otel/profiles_test.go` around lines 380 - 405, Extend
TestInitMetricsOnlyProfile with metrics_push_interval set to 301 and verify Init
succeeds without panic while retaining the metrics-only assertions. This must
exercise the out-of-range interval handling in buildTarget when target.client is
nil.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@plugins/otel/main.go`:
- Around line 565-583: Guard the client close operation in the profile cleanup
or validation flow around target.client so metrics-only profiles with no trace
client do not dereference nil. Preserve the existing validation error for
metrics_push_interval values above 300 and only close target.client when it has
been initialized.

In `@tests/e2e/features/observability/pages/observability.page.ts`:
- Around line 182-186: Update isMetricsEndpointVisible to select the
otel-profile-0-tab-metrics tab after selectConnector('otel') and before checking
the metrics locators. Wait for the tab to be visible, then click it so the
Metrics content is mounted before evaluating visibility.

---

Outside diff comments:
In `@plugins/otel/main.go`:
- Around line 593-599: Guard target.client before calling Close() in the
pushInterval > 300 validation branch, matching the nil-safe handling in the
neighboring branches. Preserve the existing error return for invalid
metrics_push_interval values while preventing a panic for metrics-only profiles.

---

Nitpick comments:
In `@plugins/otel/profiles_test.go`:
- Around line 380-405: Extend TestInitMetricsOnlyProfile with
metrics_push_interval set to 301 and verify Init succeeds without panic while
retaining the metrics-only assertions. This must exercise the out-of-range
interval handling in buildTarget when target.client is nil.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b6895736-80de-49b8-8de8-53d105e8d952

📥 Commits

Reviewing files that changed from the base of the PR and between 8110df8 and a8828bc.

📒 Files selected for processing (6)

• plugins/otel/main.go
• plugins/otel/profiles_test.go
• tests/e2e/features/observability/pages/observability.page.ts
• transports/config.schema.json
• ui/app/workspace/observability/fragments/otelFormFragment.tsx
• ui/lib/types/schemas.ts

[akshaydeo]

Merge activity

• Aug 10, 3:13 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Aug 10, 3:16 PM UTC: @akshaydeo merged this pull request with Graphite.

The base branch was changed.