chore: update helm-charts for OTEL trace / metrics headers changes by roroghost17 · Pull Request #5941 · maximhq/bifrost

roroghost17 · 2026-08-07T08:18:13Z

Summary

Adds traces_enabled, trace_headers, and metrics_headers fields to the OTEL plugin configuration (both single-profile and multi-profile shapes), enabling metrics-only OTEL profiles and per-signal header overrides.

Changes

Added traces_enabled boolean to OTEL config. When set to false, trace export is skipped and collector_url / trace_type are no longer required, allowing a metrics-only profile to be configured without a trace collector.
Added trace_headers and metrics_headers maps to OTEL config. The existing headers field continues to apply to both endpoints; trace_headers and metrics_headers are overlaid on top per-signal, with the more specific key winning on conflict. This supports cases where a collector requires a signal-specific header (e.g. a Databricks table name on the metrics endpoint only).
Updated validation logic in _helpers.tpl so that collector_url and trace_type are only required when traces_enabled is true, and protocol is only required when at least one of traces or metrics is enabled.
Updated values.schema.json conditional validation (allOf/if/then) to reflect the same rules: collector_url, trace_type, and protocol are gated on both enabled and traces_enabled not being false; metrics_endpoint and protocol are required together when metrics_enabled is true.
Updated values.yaml comments and README.md changelog to document the new fields.

Type of change

Affected areas

How to test

Deploy the Helm chart with a metrics-only OTEL profile and verify that no trace collector URL is required:

bifrost:
  plugins:
    otel:
      enabled: true
      config:
        traces_enabled: false
        metrics_enabled: true
        metrics_endpoint: "http://otel-collector:4318/v1/metrics"
        protocol: "http"
        metrics_headers:
          x-databricks-table: "my_table"

helm template . -f values.yaml | grep -A 30 "otel"
# Expect: traces_enabled: false, metrics_headers present, no collector_url validation error

helm lint .
# Expect: no schema validation errors

Verify that omitting collector_url with traces_enabled: false passes linting, and that omitting it with traces_enabled: true (default) still fails with the appropriate error message.

Screenshots/Recordings

N/A

Breaking changes

Yes
No

Related issues

N/A

Security considerations

trace_headers and metrics_headers support the env.VAR_NAME prefix for injecting secrets from environment variables, consistent with the existing headers field. No new secret handling mechanisms are introduced.

Checklist

I read docs/contributing/README.md and followed the guidelines
I added/updated tests where appropriate
I updated documentation where needed
I verified builds succeed (Go and UI)
I verified the CI pipeline passes locally if applicable

coderabbitai · 2026-08-07T08:18:21Z

📝 Walkthrough

Summary by CodeRabbit

New Features
- Added independent control for exporting traces, enabling metrics-only OpenTelemetry configurations.
- Added separate headers for trace and metrics endpoints, with support for shared header defaults.
- Added validation for required OpenTelemetry protocol and endpoint settings based on enabled signals.
Documentation
- Updated configuration examples and changelog documentation for the new OpenTelemetry options.

Walkthrough

The Helm chart adds independent OTEL trace control, trace and metrics header overrides, and conditional validation for profile-based and top-level configurations. Values examples and release notes document the new options.

Changes

OTEL configuration

Layer / File(s)	Summary
OTEL schema contracts `helm-charts/bifrost/values.schema.json`	The schema adds `traces_enabled`, `trace_headers`, and `metrics_headers`. Trace and metrics requirements are conditional on the enabled signals.
OTEL template wiring and validation `helm-charts/bifrost/templates/_helpers.tpl`	Templates pass independent trace settings and signal-specific headers. Profile-based and top-level validation apply the updated conditions.
OTEL examples and release notes `helm-charts/bifrost/values.yaml`, `helm-charts/bifrost/README.md`	Examples and release notes document metrics-only profiles, shared headers, and endpoint-specific header overrides.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

maximhq/bifrost#5939: Adds related independent OTEL trace and metrics configuration.
maximhq/bifrost#5940: Adds related signal-specific OTEL headers.
maximhq/bifrost#5942: Updates related OTEL schema, template, and validation handling.

Suggested reviewers: akshaydeo, bearts, pratham-mishra04

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly identifies the OTEL Helm chart header changes and is concise, although it does not mention metrics-only trace configuration.
Description check	✅ Passed	The description covers the purpose, changes, testing steps, affected area, breaking changes, security, and documentation updates.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 08-07-chore_update_helm-charts_for_otel_trace___metrics_headers_changes

_{Comment @coderabbitai help to get the list of available commands.}

CLAassistant · 2026-08-07T08:18:24Z

All committers have signed the CLA.

roroghost17 · 2026-08-07T08:18:30Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@helm-charts/bifrost/values.schema.json`:
- Line 5046: Update the metrics validation condition in the profile schema
around the required metrics_endpoint and protocol rule so it is skipped when the
profile’s enabled property is false, matching the existing trace validation
behavior. Ensure stale metrics_enabled values cannot require metrics fields for
disabled profiles.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 92752653-8904-4cdc-b04c-00bb55383208

📥 Commits

Reviewing files that changed from the base of the PR and between e48d172 and e718291.

📒 Files selected for processing (4)

helm-charts/bifrost/README.md
helm-charts/bifrost/templates/_helpers.tpl
helm-charts/bifrost/values.schema.json
helm-charts/bifrost/values.yaml

…OTEL

…lector

akshaydeo · 2026-08-10T15:13:03Z

Merge activity

Aug 10, 3:13 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Aug 10, 3:20 PM UTC: @akshaydeo merged this pull request with Graphite.

The base branch was changed.

…5941) Adds `traces_enabled`, `trace_headers`, and `metrics_headers` fields to the OTEL plugin configuration (both single-profile and multi-profile shapes), enabling metrics-only OTEL profiles and per-signal header overrides. - Added `traces_enabled` boolean to OTEL config. When set to `false`, trace export is skipped and `collector_url` / `trace_type` are no longer required, allowing a metrics-only profile to be configured without a trace collector. - Added `trace_headers` and `metrics_headers` maps to OTEL config. The existing `headers` field continues to apply to both endpoints; `trace_headers` and `metrics_headers` are overlaid on top per-signal, with the more specific key winning on conflict. This supports cases where a collector requires a signal-specific header (e.g. a Databricks table name on the metrics endpoint only). - Updated validation logic in `_helpers.tpl` so that `collector_url` and `trace_type` are only required when `traces_enabled` is `true`, and `protocol` is only required when at least one of traces or metrics is enabled. - Updated `values.schema.json` conditional validation (`allOf`/`if`/`then`) to reflect the same rules: `collector_url`, `trace_type`, and `protocol` are gated on both `enabled` and `traces_enabled` not being `false`; `metrics_endpoint` and `protocol` are required together when `metrics_enabled` is `true`. - Updated `values.yaml` comments and `README.md` changelog to document the new fields. - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [ ] UI (React) - [ ] Docs Deploy the Helm chart with a metrics-only OTEL profile and verify that no trace collector URL is required: ```yaml bifrost: plugins: otel: enabled: true config: traces_enabled: false metrics_enabled: true metrics_endpoint: "http://otel-collector:4318/v1/metrics" protocol: "http" metrics_headers: x-databricks-table: "my_table" ``` ```sh helm template . -f values.yaml | grep -A 30 "otel" helm lint . ``` Verify that omitting `collector_url` with `traces_enabled: false` passes linting, and that omitting it with `traces_enabled: true` (default) still fails with the appropriate error message. N/A - [ ] Yes - [x] No N/A `trace_headers` and `metrics_headers` support the `env.VAR_NAME` prefix for injecting secrets from environment variables, consistent with the existing `headers` field. No new secret handling mechanisms are introduced. - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [x] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

This was referenced Aug 7, 2026

chore: doc fixes for config.schema.json #5938

Merged

feat: add support for separate metrics tab independent of traces for OTEL #5939

Merged

This was referenced Aug 7, 2026

feat: add separate headers support for traces and metrics in OTEL collector #5940

Merged

docs: add OTEL trace / metrics headers doc and fixes the pushed metrics list #5942

Merged

roroghost17 marked this pull request as ready for review August 7, 2026 08:20

roroghost17 requested a review from a team as a code owner August 7, 2026 08:20

coderabbitai Bot requested review from BearTS, Pratham-Mishra04 and akshaydeo August 7, 2026 08:21

coderabbitai Bot requested changes Aug 7, 2026

View reviewed changes

Comment thread helm-charts/bifrost/values.schema.json

roroghost17 added 4 commits August 7, 2026 14:21

chore: doc fixes for config.schema.json

82e6184

feat: add support for separate metrics tab independent of traces for …

ebbecb6

…OTEL

feat: add separate headers support for traces and metrics in OTEL col…

a6883e2

…lector

chore: update helm-charts for OTEL trace / metrics headers changes

8bf75e3

roroghost17 force-pushed the 08-07-feat_add_separate_headers_support_for_traces_and_metrics_in_otel_collector branch from e48d172 to a6883e2 Compare August 7, 2026 09:49

roroghost17 force-pushed the 08-07-chore_update_helm-charts_for_otel_trace___metrics_headers_changes branch from e718291 to 8bf75e3 Compare August 7, 2026 09:49

coderabbitai Bot previously approved these changes Aug 7, 2026

View reviewed changes

akshaydeo changed the base branch from 08-07-feat_add_separate_headers_support_for_traces_and_metrics_in_otel_collector to graphite-base/5941 August 10, 2026 15:18

akshaydeo changed the base branch from graphite-base/5941 to dev August 10, 2026 15:20

akshaydeo merged commit 8711784 into dev Aug 10, 2026
9 of 10 checks passed

akshaydeo deleted the 08-07-chore_update_helm-charts_for_otel_trace___metrics_headers_changes branch August 10, 2026 15:20

coderabbitai Bot mentioned this pull request Aug 10, 2026

Helm chart: mcp.clientConfigs[].perUserHeaderKeys not rendered into config.json #6033

Open

This was referenced Aug 13, 2026

chore: release Bifrost Helm chart v2.1.35 with MCP OAuth, setup token, and governance enhancements #6129

Merged

chore: release Bifrost Helm chart v2.1.35 with MCP OAuth, setup token, and governance enhancements #6130

Closed

coderabbitai Bot mentioned this pull request Aug 19, 2026

[Feature]: Project CrowdStrike AIDR security evidence into OTel and trace analytics #6287

Closed

Navigation Menu

Uh oh!

chore: update helm-charts for OTEL trace / metrics headers changes - #5941

chore: update helm-charts for OTEL trace / metrics headers changes#5941
akshaydeo merged 4 commits into
devfrom
08-07-chore_update_helm-charts_for_otel_trace___metrics_headers_changes

roroghost17 commented Aug 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

CLAassistant commented Aug 7, 2026 •

edited

Loading

Uh oh!

roroghost17 commented Aug 7, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

akshaydeo commented Aug 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

roroghost17 commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of change

Affected areas

How to test

Screenshots/Recordings

Breaking changes

Related issues

Security considerations

Checklist

Uh oh!

coderabbitai Bot commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

Uh oh!

CLAassistant commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roroghost17 commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akshaydeo commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

roroghost17 commented Aug 7, 2026 •

edited

Loading

coderabbitai Bot commented Aug 7, 2026 •

edited

Loading

CLAassistant commented Aug 7, 2026 •

edited

Loading

roroghost17 commented Aug 7, 2026 •

edited

Loading

akshaydeo commented Aug 10, 2026 •

edited

Loading