feat: add user_name, team_ids, team_names, customer_ids, customer_names, business_unit_ids, business_unit_names to log list select columns - #4866
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughThe ChangesLog list query columns
Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
18 tasks
impoiler
force-pushed
the
07-02-fix_extra_column_accessors_for_logs_table
branch
from
July 2, 2026 18:35
2452cf2 to
995af61
Compare
impoiler
force-pushed
the
07-03-fix_add_extra_columns_in_api_logs_api
branch
from
July 2, 2026 18:35
0530e07 to
d24da7f
Compare
user_name and plural team/customer/business_unit fields to log list select columnsuser_name, team_ids, team_names, customer_ids, customer_names, business_unit_ids, business_unit_names to log list select columns
impoiler
marked this pull request as ready for review
July 2, 2026 18:41
Contributor
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@framework/logstore/rdb.go`:
- Around line 866-868: The list query in rdb.go is now selecting the new name
fields, but the list response path does not mask them before serialization.
Update the logstore list/query flow around the query builder and result handling
so user_name, team_names, customer_names, and business_unit_names are passed
through the same masking/access-control logic already used for selected-key,
virtual-key, and routing-rule objects, using the relevant list-response handler
or row-mapping code that processes these fields.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: fcc60f04-7419-4c8c-951d-a18d16c525c0
📒 Files selected for processing (1)
framework/logstore/rdb.go
impoiler
force-pushed
the
07-02-fix_extra_column_accessors_for_logs_table
branch
from
July 3, 2026 04:29
995af61 to
b9f6c9d
Compare
impoiler
force-pushed
the
07-03-fix_add_extra_columns_in_api_logs_api
branch
from
July 3, 2026 04:29
d24da7f to
14861ba
Compare
Contributor
Merge activity
|
akshaydeo
changed the base branch from
07-02-fix_extra_column_accessors_for_logs_table
to
graphite-base/4866
July 3, 2026 04:35
akshaydeo
dismissed
coderabbitai[bot]’s stale review
July 3, 2026 04:35
The base branch was changed.
yangtuooc
added a commit
to yangtuooc/bifrost
that referenced
this pull request
Jul 3, 2026
* upstream/dev: feat: adds multiple teams / customers / bus to connectors (maximhq#4875) fix: small latency return fixes (maximhq#4876) Added missing OpenAI responses methods for lifecycle related tasks (maximhq#3125) feat: latency info on errors (maximhq#4867) feat: add `user_name`, `team_ids`, `team_names`, `customer_ids`, `customer_names`, `business_unit_ids`, `business_unit_names` to log list select columns (maximhq#4866) feat: add multi-value attribution cell with plural fallback for logs columns (maximhq#4865)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Expands the log store query to include additional user, team, customer, and business unit fields when listing log entries.
Changes
user_nameto the select columns alongsideuser_idteam_ids,team_names,customer_ids,customer_names,business_unit_ids,business_unit_names) to support multi-value relationships on log entriesType of change
Affected areas
How to test
go test ./...Query the log listing endpoint and verify that
user_name,team_ids,team_names,customer_ids,customer_names,business_unit_ids, andbusiness_unit_namesare returned in the response.Screenshots/Recordings
N/A
Breaking changes
Related issues
Security considerations
The newly selected columns (
user_name,team_ids,team_names,customer_ids,customer_names,business_unit_ids,business_unit_names) may contain PII. Ensure existing access control and data masking policies cover these fields before deploying.Checklist
docs/contributing/README.mdand followed the guidelines