fix: broaden Mantle model matching to all `gpt` variants by Pratham-Mishra04 · Pull Request #4091 · maximhq/bifrost

Pratham-Mishra04 · 2026-06-05T14:45:07Z

Summary

Broadens the Bedrock Mantle model routing logic to support any GPT-based model, rather than only the specific gpt-oss variant.

Changes

isMantleModel now matches any model string containing "gpt" instead of only those containing "gpt-oss", enabling routing of a wider range of GPT models (e.g., gpt-4, gpt-4o, future variants) through the Bedrock Mantle endpoint.

Type of change

Affected areas

How to test

go test ./core/providers/bedrock/...

Verify that models with names containing "gpt" (e.g., gpt-4, gpt-4o, openai.gpt-4) are correctly routed to the Mantle endpoint, and that non-GPT models are not.

Screenshots/Recordings

N/A

Breaking changes

Yes
No

Related issues

Security considerations

No security implications. This change only affects internal routing logic for model selection.

Checklist

I read docs/contributing/README.md and followed the guidelines
I added/updated tests where appropriate
I updated documentation where needed
I verified builds succeed (Go and UI)
I verified the CI pipeline passes locally if applicable

Summary by CodeRabbit

Bug Fixes
- Extended support for GPT models to utilize the Bedrock Mantle endpoint.

CLAassistant · 2026-06-05T14:45:19Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Pratham-Mishra04 · 2026-06-05T14:45:55Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2026-06-05T14:45:56Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: f27337b1-e77b-4161-8fa7-8d9aa9c43bac

📥 Commits

Reviewing files that changed from the base of the PR and between 6805434 and 2916c97.

📒 Files selected for processing (1)

core/providers/bedrock/mantle.go

📝 Walkthrough

Walkthrough

The Bedrock Mantle integration's model routing predicate is broadened from checking for the specific substring "gpt-oss" to checking for any occurrence of "gpt-", which captures a wider range of GPT model identifiers and routes them to Mantle endpoints.

Changes

Bedrock Mantle Model Routing

Layer / File(s)	Summary
Broaden Mantle model predicate `core/providers/bedrock/mantle.go`	The `isMantleModel` function now detects Mantle-routed models by checking for the substring `"gpt-"` instead of `"gpt-oss"`, expanding model coverage to include all GPT hyphenated variants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Possibly related PRs

maximhq/bifrost#3489: Both PRs modify Mantle model routing logic in core/providers/bedrock/mantle.go, specifically the isMantleModel predicate used to redirect GPT model strings to Bedrock Mantle endpoints.

Suggested reviewers

akshaydeo
danpiths

Poem

🐰 A broader net for GPT models cast,
From just one pattern to a wider path,
"gpt-" now routes them all to Mantle's care,
With hyphens matched throughout the air!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: broadening Mantle model matching from 'gpt-oss' to all 'gpt' variants, which aligns with the code change.
Description check	✅ Passed	The description covers the summary, changes, type of change, affected areas, testing instructions, and breaking changes. However, most checklist items remain unchecked despite being presented as commitments.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 06-05-feat_add_support_for_mantle_apis_for_all_gpt_models

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

greptile-apps · 2026-06-05T14:49:02Z

Confidence Score: 3/5

The change is minimal in scope but the substring match is too broad — real OpenAI model names like chatgpt-4o-latest would be silently routed to the Mantle endpoint, and there are no tests to catch regressions.

The routing guard now matches any string containing "gpt-" anywhere, including model identifiers that embed that sequence but are not intended Mantle models. A prefix-anchored check after stripping known prefixes would be safer. The absence of table-driven tests means the broader match has no regression fence.

core/providers/bedrock/mantle.go — the isMantleModel predicate needs to be tightened and covered by tests.

Important Files Changed

Filename	Overview
core/providers/bedrock/mantle.go	Changes `isMantleModel` to match any model containing `"gpt-"` instead of `"gpt-oss"` only; substring search will false-positive on `chatgpt-*` model names and no tests were added for the new behavior.

_{Reviews (1): Last reviewed commit: "feat: add support for mantle apis for al..." | Re-trigger Greptile}

akshaydeo · 2026-06-05T14:51:24Z

Merge activity

Jun 5, 2:51 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jun 5, 2:52 PM UTC: @akshaydeo merged this pull request with Graphite.

## Summary This PR bumps the Go toolchain version from `1.26.3` to `1.26.4` across all modules and CI workflows, and cuts a new release (`core` v1.5.17, `framework` v1.3.17, `transports` v1.5.9, `plugins/compat` v0.1.16, `plugins/governance` v1.5.17, and associated plugin versions) incorporating a large batch of features and fixes accumulated since the previous release. ## Changes - **Go 1.26.4** — Updated `go-version` in all GitHub Actions workflows (`e2e-tests`, `helm-release`, `pr-tests`, `release-cli`, `release-pipeline`, `snyk`) and all `go.mod` files (core, framework, transports, cli, all plugins, examples, and test modules). - **Core (v1.5.17)** — OpenAI compaction support, multi-customer logs and usage tracking, multiple team/business unit support, `request_headers` wildcard pattern capture for OTel and Maxim plugins, xAI `x_search` tool, fetch URL validation with SSRF hardening, `file://` pricing URL scheme, virtual key provider fan-out filtering, and a broad set of fixes including Anthropic prompt cache key, empty thinking block stripping, OpenAI stream usage event cleanup, Gemini numeric schema constraints, stale connection retries, Azure Claude diagnostic strip, and passthrough budget handling. - **Framework (v1.3.17)** — Scope-aware budgets and limits wired from model configs, provider-level governance, multiple customer budget support with `calendar_aligned` windows, paginated virtual key fetch, `config.json` source-of-truth flow, FTS index cap reduction, sync worker drift fix, cascade deletes for model configs, and high-scale virtual key flow improvements. - **Transports (v1.5.9)** — Full changelog covering all of the above plus UI improvements (log navigation, customer detail sheet, `BudgetDisplay` component, inline loading shell, materialized view alias), SCIM provisioning fields, Helm/config schema additions (`roles`, `per_user_oauth`), client IP resolution from forwarded headers, and dependency upgrades (`recharts` to 3.8.1, `golang.org/x` CVE remediation). - **Plugins** — `governance` v1.5.17 adds team budget/rate-limit exporters, ghost node reconciliation fix, and VK double usage counting fix; `logging` v1.5.17 adds wildcard header capture and file attachment rendering; `otel` v1.2.17 adds `disable_content_logging` and multiple collectors support; `maxim` v1.6.17 adds `request_headers` wildcard capture; `compat` v0.1.16 fixes `max_tokens` preservation during param filtering. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [x] Core (Go) - [x] Transports (HTTP) - [x] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh # Verify Go version go version # should report go1.26.4 # Run core tests cd core && go test ./... # Run framework tests cd framework && go test ./... # Run transports tests cd transports && go test ./... # Run plugin tests cd plugins/governance && go test ./... cd plugins/logging && go test ./... cd plugins/otel && go test ./... # UI cd ui pnpm i pnpm build pnpm test ``` ## Breaking changes - [ ] Yes - [x] No ## Related issues #4053, #4066, #4041, #4012, #3976, #3947, #3991, #4045, #3957, #3938, #3937, #3939, #3981, #3998, #3997, #4092, #4091, #4079, #4080, #4086, #3929, #3994, #4028, #3970, #3919, #3861, #3664, #3999, #4088, #4070, #4051, #4043, #4057, #4023, #3941, #3955, #4024, #3956, #3967, #3925, #3992, #3900 ## Security considerations - Fetch URL validation hardened against SSRF by tightening IP checks for private networks and link-local addresses (#4092, #3947, #3991). - Transitive `golang.org/x` dependencies (crypto, net, sys, text) bumped to address Docker Scout CVEs (#3900). ## Checklist - [x] I read `docs/contributing/README.md` and followed the guidelines - [x] I added/updated tests where appropriate - [x] I updated documentation where needed - [x] I verified builds succeed (Go and UI) - [x] I verified the CI pipeline passes locally if applicable  ## Summary by CodeRabbit * **New Features** * OpenAI compaction, multi-customer/team logstore support, request-header wildcard capture, enhanced governance (provider-level & scope-aware limits), disable-content-logging option, support for multiple OpenTelemetry collectors, SSRF hardening and URL validation. * **Chores** * Bumped Go toolchain across modules and updated component/plugin version releases.

## Summary Broadens the Bedrock Mantle model routing logic to support any GPT-based model, rather than only the specific `gpt-oss` variant. ## Changes - `isMantleModel` now matches any model string containing `"gpt"` instead of only those containing `"gpt-oss"`, enabling routing of a wider range of GPT models (e.g., `gpt-4`, `gpt-4o`, future variants) through the Bedrock Mantle endpoint. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [x] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test ```sh go test ./core/providers/bedrock/... ``` Verify that models with names containing `"gpt"` (e.g., `gpt-4`, `gpt-4o`, `openai.gpt-4`) are correctly routed to the Mantle endpoint, and that non-GPT models are not. ## Screenshots/Recordings N/A ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations No security implications. This change only affects internal routing logic for model selection. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable  ## Summary by CodeRabbit * **Bug Fixes** * Extended support for GPT models to utilize the Bedrock Mantle endpoint.

@chris-colinsky

## ✨ Features - **OpenAI Compaction** — Added OpenAI conversation compaction support across core, framework, logging, and the API surface (#4053) - **Multi-Customer & Org Hierarchy** — Logs and usage tracking now support multiple customers, teams, and business units, including business unit CRUD, team assignment, and governance endpoints in the OpenAPI spec (#4066, #4041, #4082) - **Provider-Level Governance** — Budgets & limits are now scope-aware and can be applied at the virtual-key top level and per provider, wired from the model configs table, with UI filters for scope and providers (#3938, #3937, #3939, #3981, #3962) - **Customer Budgets** — Customers support multiple budgets and `calendar_aligned` budget windows (#3998, #3997) - **Virtual Key Attribution & Controls** — Added a `created_by` user attribution column and a `blacklisted_models` column for virtual key provider configs (#3672, #3653) - **Request Header Capture** — OTel and Maxim observability plugins capture `request_headers` by pattern, with wildcard support (e.g. `x-custom-*`); logging gained the same wildcard header capture (#4012, #3958) - **OTel Content Controls & Collectors** — New `disable_content_logging` option drops message/tool content from exported spans, plus support for multiple OTel collectors (#4064, #3894) - **xAI x_search** — Added xAI `x_search` tool support (#3976) - **URL Validation** — Added fetch URL validation with private-network configuration and link-local blocking (#3947, #3991) - **File Scheme Pricing URLs** — Pricing source URLs now accept the `file://` scheme for air-gapped and self-hosted deployments (#4045) - **Paginated Virtual Keys** — Virtual key fetching is paginated to handle deployments with very large numbers of keys (#3957) - **Client IP Resolution** — Resolve client IP from `X-Forwarded-For`/`X-Real-IP` headers - **SCIM Provisioning** — Added `attributeType`/`attributeValue` SCIM provisioning fields - **Helm/Config Schema** — Added `roles` RBAC governance config and `per_user_oauth` MCP auth to the Helm chart and config schema (#4004, #4009) - **Log Navigation UI** — Added a "View logs" menu item to customer, team, and virtual key tables, clickable links in log detail views, a customer detail sheet, and a reusable `BudgetDisplay` component (#4073, #4054, #4026, #4055) - **Faster First Paint** — Added an inline loading shell to `#root` before React mounts (#4063) - **Materialized View Alias** — Added an `alias` column to the materialized view with filter support (#4078) ## 🐞 Fixed - **Fetch URL IP Checks** — Hardened fetch URL IP checks against SSRF (#4092) - **Mantle Model Matching** — Broadened Mantle model matching to all `gpt` variants (#4091) - **Empty Thinking Blocks** — Strip thinking blocks when the signature is empty (#4079) - **OpenAI Stream Usage** — Removed usage from the `responses.created` event in the OpenAI stream (#4080) - **Prompt Cache Key** — Set the prompt cache key from the Anthropic integration (#4086) - **Upstream Failure Status** — Map upstream connection failures to 502 instead of 400 (#3929) (thanks [@chris-colinsky](https://github.com/chris-colinsky)!) - **Gemini Schema Constraints** — Accept numeric schema integer constraints for Gemini (#3994) (thanks [@yanhao98](https://github.com/yanhao98)!) - **Files Provider Param** — Accept the `?provider=` query param on `GET /v1/files` (#3971) (thanks [@alexef](https://github.com/alexef)!) - **Optional Batch Model** — Made the `model` field optional on `POST /v1/batches` (#3973) (thanks [@alexef](https://github.com/alexef)!) - **Helm Azure Config** — Added missing `azure_key_config` fields to the Helm schema (#3996) (thanks [@axelray-dev](https://github.com/axelray-dev)!) - **Text Completion Chunk Model** — Added the missing `Model` field to `TextCompletionChunkResponse` (#3970) (thanks [@kuishou68](https://github.com/kuishou68)!) - **MCP Inline stdio Env** — MCP stdio server configs accept inline environment variable assignments (#3861) (thanks [@Shushmitaaaa](https://github.com/Shushmitaaaa)!) - **Orphaned Tool Results** — Orphaned tool results in the OpenAI to Anthropic conversion flow are no longer rejected by the Anthropic API (#3919) - **Node Usage Reconciliation** — Added a monotonic `inc_number` log cursor so node usage reconciliation does not skip late async log writes (#3664) - **Bedrock Output Assessments** — Corrected the type of `outputAssessments` in Bedrock responses (#4028) - **Model Pool Pricing Reloads** — Preserve non-pricing model pool entries across pricing reloads (#3999) - **Ghost Node Reconciliation** — Replicate the VK hierarchy flow for ghost node reconciliation (#4088) - **VK Double Usage Counting** — Fixed double usage counting when creating a virtual key (#4070) - **Model Config Lifecycle** — Cascade deletes for model configs and removal of stale in-memory model configs (#4051, #4043) - **FTS Index Cap** — Reduced the FTS index `left()` cap from 800k to 250k chars to stay within the tsvector limit (#4057) - **Sync Worker Drift** — Reduced the sync worker ticker period to 5m to prevent threshold drift (#4023) - **Passthrough** — Fixed passthrough budgets, gated passthrough models per VK, model extraction for Azure passthrough, and restricted fallbacks/provider selection to the VK boundary (#3941, #3988, #3983, #3924) - **Provider Response Headers** — Strip provider response headers and add a content-type filter (#3955, #4024) - **Stream Handling** — Drain non-SSE stream readers and retry stale connections (#3956, #3967) - **Azure Claude** — Strip Azure diagnostic property for Claude models (#3925) - **Compat max_tokens** — Preserve chat `max_tokens` during param filtering (#3992) - **Raw Request Flag** — Removed the raw request flag from providers that don't support it (#4058) - **UI Fixes** — Standardized page container layout, virtual key model configs UI, and dashboard chart tooltips (#4046, #4052, #4044) ## 🔧 Maintenance - **Dependency Upgrades** — Bumped transitive `golang.org/x` dependencies (crypto, net, sys, text) for Docker Scout CVE remediation and `recharts` to 3.8.1; cascaded version bumps across all modules (#3900, #4003)

test: governance test fixes

6805434

Pratham-Mishra04 requested review from akshaydeo and danpiths June 5, 2026 14:45

feat: add support for mantle apis for all gpt models

2916c97

Pratham-Mishra04 force-pushed the 06-05-feat_add_support_for_mantle_apis_for_all_gpt_models branch from ffaf4a8 to 2916c97 Compare June 5, 2026 14:46

greptile-apps Bot reviewed Jun 5, 2026

View reviewed changes

Comment thread core/providers/bedrock/mantle.go

Comment thread core/providers/bedrock/mantle.go

akshaydeo changed the base branch from 06-05-test_governance_test_fixes to graphite-base/4091 June 5, 2026 14:51

akshaydeo changed the base branch from graphite-base/4091 to dev June 5, 2026 14:51

akshaydeo merged commit 582923f into dev Jun 5, 2026
10 of 11 checks passed

akshaydeo deleted the 06-05-feat_add_support_for_mantle_apis_for_all_gpt_models branch June 5, 2026 14:52

akshaydeo mentioned this pull request Jun 5, 2026

changelogs and go upgrade to 1.26.4 #4096

Merged

18 tasks

akshaydeo mentioned this pull request Jun 7, 2026

v1.5.9 #4120

Merged

This was referenced Jun 12, 2026

normalizeOpenAIReasoningEffort maps 'max' → 'high' for DeepSeek V4 models, but DeepSeek V4 natively supports 'max' #4320

Closed

GLM-5.2 reasoning_effort "max" silently downgraded to "high" (same normalization gap as #4320 for DeepSeek V4) #4460

Closed

Navigation Menu

Uh oh!

fix: broaden Mantle model matching to all `gpt` variants - #4091

fix: broaden Mantle model matching to all `gpt` variants#4091
akshaydeo merged 2 commits into
devfrom
06-05-feat_add_support_for_mantle_apis_for_all_gpt_models

Pratham-Mishra04 commented Jun 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

CLAassistant commented Jun 5, 2026

Uh oh!

Pratham-Mishra04 commented Jun 5, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

greptile-apps Bot commented Jun 5, 2026

Uh oh!

Uh oh!

Uh oh!

akshaydeo commented Jun 5, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Pratham-Mishra04 commented Jun 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of change

Affected areas

How to test

Screenshots/Recordings

Breaking changes

Related issues

Security considerations

Checklist

Summary by CodeRabbit

Uh oh!

CLAassistant commented Jun 5, 2026

Uh oh!

Pratham-Mishra04 commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

greptile-apps Bot commented Jun 5, 2026

Confidence Score: 3/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

akshaydeo commented Jun 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Pratham-Mishra04 commented Jun 5, 2026 •

edited by coderabbitai Bot

Loading

Pratham-Mishra04 commented Jun 5, 2026 •

edited

Loading

coderabbitai Bot commented Jun 5, 2026 •

edited

Loading

akshaydeo commented Jun 5, 2026 •

edited

Loading