fix(files): accept ?provider= query param on GET /v1/files

[alexef]

Fixes #3963

Problem

fileList checked ?x-model-provider= as a query parameter name while all other file endpoints (GET /v1/files/{id}, DELETE /v1/files/{id}, etc.) use ?provider=. This meant the standard OpenAI SDK pattern of passing extra_query={"provider": "..."} always failed with a 400 on GET /v1/files.

// before — wrong query param name
provider := string(ctx.QueryArgs().Peek("x-model-provider"))

Fix

Check ?provider= first (consistent with all other file endpoints), then fall back to ?x-model-provider= and the x-model-provider header.

Testing

• GET /v1/files?provider=openai now accepted
• GET /v1/files?x-model-provider=openai still works (backwards compatible)
• x-model-provider header still works

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Enhanced request handling to support multiple ways of specifying the model provider parameter with clear precedence order for parameters and headers.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ alexef
❌ akshaydeo
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: cd1083d5-9217-4e9c-bdbb-9c176c87bbe6

📥 Commits

Reviewing files that changed from the base of the PR and between 7474c06 and ee0b657.

📒 Files selected for processing (1)

• transports/bifrost-http/handlers/inference.go

---

📝 Walkthrough

Walkthrough

The fileList handler in the HTTP inference transport was updated to resolve the provider parameter from multiple sources in a new precedence order: the ?provider query parameter first, then ?x-model-provider query parameter, and finally the x-model-provider header. The validation error message was updated to reflect the new lookup behavior.

Changes

Provider parameter resolution in fileList

Layer / File(s)	Summary
fileList provider parameter precedence transports/bifrost-http/handlers/inference.go	fileList now reads provider from the provider query parameter first, then from x-model-provider query parameter, and finally from the x-model-provider header, bringing consistency to provider resolution across Files API endpoints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit hops through parameter chains,
First ?provider, then back again,
To x-model-provider if needed be,
One source before the rest, clean and free! 🐰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and accurately describes the main change: accepting the ?provider= query parameter on the GET /v1/files endpoint.
Description check	✅ Passed	The PR description includes the linked issue reference, clear problem statement, and the fix explanation with test cases, meeting most template requirements.
Linked Issues check	✅ Passed	The PR fixes issue #3963 by implementing the exact requirement: making GET /v1/files check ?provider= first while maintaining backward compatibility with ?x-model-provider=.
Out of Scope Changes check	✅ Passed	All changes are focused on the fileList request handling in the inference handler, directly addressing the linked issue with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Confidence Score: 5/5

This is a safe, minimal change that restores the correct query-parameter name for a single handler.

The change is a one-function fix that makes fileList consistent with every other file-endpoint handler in the same file. The fallback chain (?provider= → ?x-model-provider= → x-model-provider header) is backwards-compatible and matches the pattern used by fileUpload. No shared state, no concurrency implications, and no downstream behaviour is affected beyond the corrected parameter lookup.

No files require special attention.

Important Files Changed

Filename	Overview
transports/bifrost-http/handlers/inference.go	Fixes fileList to accept ?provider= first (matching all other file endpoints), then falls back to ?x-model-provider= and the x-model-provider header for backwards compatibility; error message updated accordingly.

_{Reviews (3): Last reviewed commit: "Merge branch 'dev' into fix/batch-create..." | Re-trigger Greptile}