fix: replicates vk hierarchy flow for ghost nodes reconcilation - #4088
Conversation
|
Warning Review limit reached
More reviews will be available in 18 minutes and 59 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Confidence Score: 4/5Safe to merge; the logic change is small and well-tested, and the call site correctly keeps user and VK paths mutually exclusive. The core change — inserting a user-scoped model-config walk guarded by No files require special attention; the one style note is in the interface comment block of Important Files Changed
Reviews (1): Last reviewed commit: "fix: replicates vk hierarchy flow for gh..." | Re-trigger Greptile |
Merge activity
|
## Summary This PR bumps the Go toolchain version from `1.26.3` to `1.26.4` across all modules and CI workflows, and cuts a new release (`core` v1.5.17, `framework` v1.3.17, `transports` v1.5.9, `plugins/compat` v0.1.16, `plugins/governance` v1.5.17, and associated plugin versions) incorporating a large batch of features and fixes accumulated since the previous release. ## Changes - **Go 1.26.4** — Updated `go-version` in all GitHub Actions workflows (`e2e-tests`, `helm-release`, `pr-tests`, `release-cli`, `release-pipeline`, `snyk`) and all `go.mod` files (core, framework, transports, cli, all plugins, examples, and test modules). - **Core (v1.5.17)** — OpenAI compaction support, multi-customer logs and usage tracking, multiple team/business unit support, `request_headers` wildcard pattern capture for OTel and Maxim plugins, xAI `x_search` tool, fetch URL validation with SSRF hardening, `file://` pricing URL scheme, virtual key provider fan-out filtering, and a broad set of fixes including Anthropic prompt cache key, empty thinking block stripping, OpenAI stream usage event cleanup, Gemini numeric schema constraints, stale connection retries, Azure Claude diagnostic strip, and passthrough budget handling. - **Framework (v1.3.17)** — Scope-aware budgets and limits wired from model configs, provider-level governance, multiple customer budget support with `calendar_aligned` windows, paginated virtual key fetch, `config.json` source-of-truth flow, FTS index cap reduction, sync worker drift fix, cascade deletes for model configs, and high-scale virtual key flow improvements. - **Transports (v1.5.9)** — Full changelog covering all of the above plus UI improvements (log navigation, customer detail sheet, `BudgetDisplay` component, inline loading shell, materialized view alias), SCIM provisioning fields, Helm/config schema additions (`roles`, `per_user_oauth`), client IP resolution from forwarded headers, and dependency upgrades (`recharts` to 3.8.1, `golang.org/x` CVE remediation). - **Plugins** — `governance` v1.5.17 adds team budget/rate-limit exporters, ghost node reconciliation fix, and VK double usage counting fix; `logging` v1.5.17 adds wildcard header capture and file attachment rendering; `otel` v1.2.17 adds `disable_content_logging` and multiple collectors support; `maxim` v1.6.17 adds `request_headers` wildcard capture; `compat` v0.1.16 fixes `max_tokens` preservation during param filtering. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [x] Core (Go) - [x] Transports (HTTP) - [x] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh # Verify Go version go version # should report go1.26.4 # Run core tests cd core && go test ./... # Run framework tests cd framework && go test ./... # Run transports tests cd transports && go test ./... # Run plugin tests cd plugins/governance && go test ./... cd plugins/logging && go test ./... cd plugins/otel && go test ./... # UI cd ui pnpm i pnpm build pnpm test ``` ## Breaking changes - [ ] Yes - [x] No ## Related issues #4053, #4066, #4041, #4012, #3976, #3947, #3991, #4045, #3957, #3938, #3937, #3939, #3981, #3998, #3997, #4092, #4091, #4079, #4080, #4086, #3929, #3994, #4028, #3970, #3919, #3861, #3664, #3999, #4088, #4070, #4051, #4043, #4057, #4023, #3941, #3955, #4024, #3956, #3967, #3925, #3992, #3900 ## Security considerations - Fetch URL validation hardened against SSRF by tightening IP checks for private networks and link-local addresses (#4092, #3947, #3991). - Transitive `golang.org/x` dependencies (crypto, net, sys, text) bumped to address Docker Scout CVEs (#3900). ## Checklist - [x] I read `docs/contributing/README.md` and followed the guidelines - [x] I added/updated tests where appropriate - [x] I updated documentation where needed - [x] I verified builds succeed (Go and UI) - [x] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * OpenAI compaction, multi-customer/team logstore support, request-header wildcard capture, enhanced governance (provider-level & scope-aware limits), disable-content-logging option, support for multiple OpenTelemetry collectors, SSRF hardening and URL validation. * **Chores** * Bumped Go toolchain across modules and updated component/plugin version releases. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
## Summary `CollectApplicableGovernanceIDs` previously only walked the virtual-key hierarchy when collecting budget and rate-limit IDs to stamp on log rows. User-scoped model configs were never included, meaning any usage governed by a user-level model config would silently vanish from cluster baselines when a node ghosted during reconciliation. ## Changes - Added a `userID string` parameter to `CollectApplicableGovernanceIDs` on both the `GovernanceStore` interface and the `LocalGovernanceStore` implementation. - After collecting provider/model/VK-hierarchy IDs, the function now also walks user-scoped model configs (when `userID` and `model` are non-empty), appending their budget and rate-limit IDs to the result sets. - Updated the call site in `PostLLMHook` to pass `userID` through to the updated signature. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [ ] UI (React) - [ ] Docs ## How to test ```sh go test ./plugins/governance/... ``` Verify that a request authenticated via a user ID (AP path) correctly stamps user-scoped model-config budget and rate-limit IDs on the resulting log row. Confirm that requests without a `userID` are unaffected and continue to stamp VK-hierarchy IDs as before. ## Breaking changes - [x] Yes - [ ] No The `GovernanceStore` interface has a new `userID string` parameter in `CollectApplicableGovernanceIDs`. Any external implementations of `GovernanceStore` must be updated to match the new signature. ## Related issues ## Security considerations No new auth surfaces introduced. The `userID` value is sourced from the existing request context and is only used for in-memory sync.Map lookups — no external I/O or privilege escalation risk. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
## ✨ Features - **OpenAI Compaction** — Added OpenAI conversation compaction support across core, framework, logging, and the API surface (#4053) - **Multi-Customer & Org Hierarchy** — Logs and usage tracking now support multiple customers, teams, and business units, including business unit CRUD, team assignment, and governance endpoints in the OpenAPI spec (#4066, #4041, #4082) - **Provider-Level Governance** — Budgets & limits are now scope-aware and can be applied at the virtual-key top level and per provider, wired from the model configs table, with UI filters for scope and providers (#3938, #3937, #3939, #3981, #3962) - **Customer Budgets** — Customers support multiple budgets and `calendar_aligned` budget windows (#3998, #3997) - **Virtual Key Attribution & Controls** — Added a `created_by` user attribution column and a `blacklisted_models` column for virtual key provider configs (#3672, #3653) - **Request Header Capture** — OTel and Maxim observability plugins capture `request_headers` by pattern, with wildcard support (e.g. `x-custom-*`); logging gained the same wildcard header capture (#4012, #3958) - **OTel Content Controls & Collectors** — New `disable_content_logging` option drops message/tool content from exported spans, plus support for multiple OTel collectors (#4064, #3894) - **xAI x_search** — Added xAI `x_search` tool support (#3976) - **URL Validation** — Added fetch URL validation with private-network configuration and link-local blocking (#3947, #3991) - **File Scheme Pricing URLs** — Pricing source URLs now accept the `file://` scheme for air-gapped and self-hosted deployments (#4045) - **Paginated Virtual Keys** — Virtual key fetching is paginated to handle deployments with very large numbers of keys (#3957) - **Client IP Resolution** — Resolve client IP from `X-Forwarded-For`/`X-Real-IP` headers - **SCIM Provisioning** — Added `attributeType`/`attributeValue` SCIM provisioning fields - **Helm/Config Schema** — Added `roles` RBAC governance config and `per_user_oauth` MCP auth to the Helm chart and config schema (#4004, #4009) - **Log Navigation UI** — Added a "View logs" menu item to customer, team, and virtual key tables, clickable links in log detail views, a customer detail sheet, and a reusable `BudgetDisplay` component (#4073, #4054, #4026, #4055) - **Faster First Paint** — Added an inline loading shell to `#root` before React mounts (#4063) - **Materialized View Alias** — Added an `alias` column to the materialized view with filter support (#4078) ## 🐞 Fixed - **Fetch URL IP Checks** — Hardened fetch URL IP checks against SSRF (#4092) - **Mantle Model Matching** — Broadened Mantle model matching to all `gpt` variants (#4091) - **Empty Thinking Blocks** — Strip thinking blocks when the signature is empty (#4079) - **OpenAI Stream Usage** — Removed usage from the `responses.created` event in the OpenAI stream (#4080) - **Prompt Cache Key** — Set the prompt cache key from the Anthropic integration (#4086) - **Upstream Failure Status** — Map upstream connection failures to 502 instead of 400 (#3929) (thanks [@chris-colinsky](https://github.com/chris-colinsky)!) - **Gemini Schema Constraints** — Accept numeric schema integer constraints for Gemini (#3994) (thanks [@yanhao98](https://github.com/yanhao98)!) - **Files Provider Param** — Accept the `?provider=` query param on `GET /v1/files` (#3971) (thanks [@alexef](https://github.com/alexef)!) - **Optional Batch Model** — Made the `model` field optional on `POST /v1/batches` (#3973) (thanks [@alexef](https://github.com/alexef)!) - **Helm Azure Config** — Added missing `azure_key_config` fields to the Helm schema (#3996) (thanks [@axelray-dev](https://github.com/axelray-dev)!) - **Text Completion Chunk Model** — Added the missing `Model` field to `TextCompletionChunkResponse` (#3970) (thanks [@kuishou68](https://github.com/kuishou68)!) - **MCP Inline stdio Env** — MCP stdio server configs accept inline environment variable assignments (#3861) (thanks [@Shushmitaaaa](https://github.com/Shushmitaaaa)!) - **Orphaned Tool Results** — Orphaned tool results in the OpenAI to Anthropic conversion flow are no longer rejected by the Anthropic API (#3919) - **Node Usage Reconciliation** — Added a monotonic `inc_number` log cursor so node usage reconciliation does not skip late async log writes (#3664) - **Bedrock Output Assessments** — Corrected the type of `outputAssessments` in Bedrock responses (#4028) - **Model Pool Pricing Reloads** — Preserve non-pricing model pool entries across pricing reloads (#3999) - **Ghost Node Reconciliation** — Replicate the VK hierarchy flow for ghost node reconciliation (#4088) - **VK Double Usage Counting** — Fixed double usage counting when creating a virtual key (#4070) - **Model Config Lifecycle** — Cascade deletes for model configs and removal of stale in-memory model configs (#4051, #4043) - **FTS Index Cap** — Reduced the FTS index `left()` cap from 800k to 250k chars to stay within the tsvector limit (#4057) - **Sync Worker Drift** — Reduced the sync worker ticker period to 5m to prevent threshold drift (#4023) - **Passthrough** — Fixed passthrough budgets, gated passthrough models per VK, model extraction for Azure passthrough, and restricted fallbacks/provider selection to the VK boundary (#3941, #3988, #3983, #3924) - **Provider Response Headers** — Strip provider response headers and add a content-type filter (#3955, #4024) - **Stream Handling** — Drain non-SSE stream readers and retry stale connections (#3956, #3967) - **Azure Claude** — Strip Azure diagnostic property for Claude models (#3925) - **Compat max_tokens** — Preserve chat `max_tokens` during param filtering (#3992) - **Raw Request Flag** — Removed the raw request flag from providers that don't support it (#4058) - **UI Fixes** — Standardized page container layout, virtual key model configs UI, and dashboard chart tooltips (#4046, #4052, #4044) ## 🔧 Maintenance - **Dependency Upgrades** — Bumped transitive `golang.org/x` dependencies (crypto, net, sys, text) for Docker Scout CVE remediation and `recharts` to 3.8.1; cascaded version bumps across all modules (#3900, #4003)
…mhq#4088) ## Summary `CollectApplicableGovernanceIDs` previously only walked the virtual-key hierarchy when collecting budget and rate-limit IDs to stamp on log rows. User-scoped model configs were never included, meaning any usage governed by a user-level model config would silently vanish from cluster baselines when a node ghosted during reconciliation. ## Changes - Added a `userID string` parameter to `CollectApplicableGovernanceIDs` on both the `GovernanceStore` interface and the `LocalGovernanceStore` implementation. - After collecting provider/model/VK-hierarchy IDs, the function now also walks user-scoped model configs (when `userID` and `model` are non-empty), appending their budget and rate-limit IDs to the result sets. - Updated the call site in `PostLLMHook` to pass `userID` through to the updated signature. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [ ] UI (React) - [ ] Docs ## How to test ```sh go test ./plugins/governance/... ``` Verify that a request authenticated via a user ID (AP path) correctly stamps user-scoped model-config budget and rate-limit IDs on the resulting log row. Confirm that requests without a `userID` are unaffected and continue to stamp VK-hierarchy IDs as before. ## Breaking changes - [x] Yes - [ ] No The `GovernanceStore` interface has a new `userID string` parameter in `CollectApplicableGovernanceIDs`. Any external implementations of `GovernanceStore` must be updated to match the new signature. ## Related issues ## Security considerations No new auth surfaces introduced. The `userID` value is sourced from the existing request context and is only used for in-memory sync.Map lookups — no external I/O or privilege escalation risk. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
## ✨ Features - **OpenAI Compaction** — Added OpenAI conversation compaction support across core, framework, logging, and the API surface (maximhq#4053) - **Multi-Customer & Org Hierarchy** — Logs and usage tracking now support multiple customers, teams, and business units, including business unit CRUD, team assignment, and governance endpoints in the OpenAPI spec (maximhq#4066, maximhq#4041, maximhq#4082) - **Provider-Level Governance** — Budgets & limits are now scope-aware and can be applied at the virtual-key top level and per provider, wired from the model configs table, with UI filters for scope and providers (maximhq#3938, maximhq#3937, maximhq#3939, maximhq#3981, maximhq#3962) - **Customer Budgets** — Customers support multiple budgets and `calendar_aligned` budget windows (maximhq#3998, maximhq#3997) - **Virtual Key Attribution & Controls** — Added a `created_by` user attribution column and a `blacklisted_models` column for virtual key provider configs (maximhq#3672, maximhq#3653) - **Request Header Capture** — OTel and Maxim observability plugins capture `request_headers` by pattern, with wildcard support (e.g. `x-custom-*`); logging gained the same wildcard header capture (maximhq#4012, maximhq#3958) - **OTel Content Controls & Collectors** — New `disable_content_logging` option drops message/tool content from exported spans, plus support for multiple OTel collectors (maximhq#4064, maximhq#3894) - **xAI x_search** — Added xAI `x_search` tool support (maximhq#3976) - **URL Validation** — Added fetch URL validation with private-network configuration and link-local blocking (maximhq#3947, maximhq#3991) - **File Scheme Pricing URLs** — Pricing source URLs now accept the `file://` scheme for air-gapped and self-hosted deployments (maximhq#4045) - **Paginated Virtual Keys** — Virtual key fetching is paginated to handle deployments with very large numbers of keys (maximhq#3957) - **Client IP Resolution** — Resolve client IP from `X-Forwarded-For`/`X-Real-IP` headers - **SCIM Provisioning** — Added `attributeType`/`attributeValue` SCIM provisioning fields - **Helm/Config Schema** — Added `roles` RBAC governance config and `per_user_oauth` MCP auth to the Helm chart and config schema (maximhq#4004, maximhq#4009) - **Log Navigation UI** — Added a "View logs" menu item to customer, team, and virtual key tables, clickable links in log detail views, a customer detail sheet, and a reusable `BudgetDisplay` component (maximhq#4073, maximhq#4054, maximhq#4026, maximhq#4055) - **Faster First Paint** — Added an inline loading shell to `#root` before React mounts (maximhq#4063) - **Materialized View Alias** — Added an `alias` column to the materialized view with filter support (maximhq#4078) ## 🐞 Fixed - **Fetch URL IP Checks** — Hardened fetch URL IP checks against SSRF (maximhq#4092) - **Mantle Model Matching** — Broadened Mantle model matching to all `gpt` variants (maximhq#4091) - **Empty Thinking Blocks** — Strip thinking blocks when the signature is empty (maximhq#4079) - **OpenAI Stream Usage** — Removed usage from the `responses.created` event in the OpenAI stream (maximhq#4080) - **Prompt Cache Key** — Set the prompt cache key from the Anthropic integration (maximhq#4086) - **Upstream Failure Status** — Map upstream connection failures to 502 instead of 400 (maximhq#3929) (thanks [@chris-colinsky](https://github.com/chris-colinsky)!) - **Gemini Schema Constraints** — Accept numeric schema integer constraints for Gemini (maximhq#3994) (thanks [@yanhao98](https://github.com/yanhao98)!) - **Files Provider Param** — Accept the `?provider=` query param on `GET /v1/files` (maximhq#3971) (thanks [@alexef](https://github.com/alexef)!) - **Optional Batch Model** — Made the `model` field optional on `POST /v1/batches` (maximhq#3973) (thanks [@alexef](https://github.com/alexef)!) - **Helm Azure Config** — Added missing `azure_key_config` fields to the Helm schema (maximhq#3996) (thanks [@axelray-dev](https://github.com/axelray-dev)!) - **Text Completion Chunk Model** — Added the missing `Model` field to `TextCompletionChunkResponse` (maximhq#3970) (thanks [@kuishou68](https://github.com/kuishou68)!) - **MCP Inline stdio Env** — MCP stdio server configs accept inline environment variable assignments (maximhq#3861) (thanks [@Shushmitaaaa](https://github.com/Shushmitaaaa)!) - **Orphaned Tool Results** — Orphaned tool results in the OpenAI to Anthropic conversion flow are no longer rejected by the Anthropic API (maximhq#3919) - **Node Usage Reconciliation** — Added a monotonic `inc_number` log cursor so node usage reconciliation does not skip late async log writes (maximhq#3664) - **Bedrock Output Assessments** — Corrected the type of `outputAssessments` in Bedrock responses (maximhq#4028) - **Model Pool Pricing Reloads** — Preserve non-pricing model pool entries across pricing reloads (maximhq#3999) - **Ghost Node Reconciliation** — Replicate the VK hierarchy flow for ghost node reconciliation (maximhq#4088) - **VK Double Usage Counting** — Fixed double usage counting when creating a virtual key (maximhq#4070) - **Model Config Lifecycle** — Cascade deletes for model configs and removal of stale in-memory model configs (maximhq#4051, maximhq#4043) - **FTS Index Cap** — Reduced the FTS index `left()` cap from 800k to 250k chars to stay within the tsvector limit (maximhq#4057) - **Sync Worker Drift** — Reduced the sync worker ticker period to 5m to prevent threshold drift (maximhq#4023) - **Passthrough** — Fixed passthrough budgets, gated passthrough models per VK, model extraction for Azure passthrough, and restricted fallbacks/provider selection to the VK boundary (maximhq#3941, maximhq#3988, maximhq#3983, maximhq#3924) - **Provider Response Headers** — Strip provider response headers and add a content-type filter (maximhq#3955, maximhq#4024) - **Stream Handling** — Drain non-SSE stream readers and retry stale connections (maximhq#3956, maximhq#3967) - **Azure Claude** — Strip Azure diagnostic property for Claude models (maximhq#3925) - **Compat max_tokens** — Preserve chat `max_tokens` during param filtering (maximhq#3992) - **Raw Request Flag** — Removed the raw request flag from providers that don't support it (maximhq#4058) - **UI Fixes** — Standardized page container layout, virtual key model configs UI, and dashboard chart tooltips (maximhq#4046, maximhq#4052, maximhq#4044) ## 🔧 Maintenance - **Dependency Upgrades** — Bumped transitive `golang.org/x` dependencies (crypto, net, sys, text) for Docker Scout CVE remediation and `recharts` to 3.8.1; cascaded version bumps across all modules (maximhq#3900, maximhq#4003)

Summary
CollectApplicableGovernanceIDspreviously only walked the virtual-key hierarchy when collecting budget and rate-limit IDs to stamp on log rows. User-scoped model configs were never included, meaning any usage governed by a user-level model config would silently vanish from cluster baselines when a node ghosted during reconciliation.Changes
userID stringparameter toCollectApplicableGovernanceIDson both theGovernanceStoreinterface and theLocalGovernanceStoreimplementation.userIDandmodelare non-empty), appending their budget and rate-limit IDs to the result sets.PostLLMHookto passuserIDthrough to the updated signature.Type of change
Affected areas
How to test
go test ./plugins/governance/...Verify that a request authenticated via a user ID (AP path) correctly stamps user-scoped model-config budget and rate-limit IDs on the resulting log row. Confirm that requests without a
userIDare unaffected and continue to stamp VK-hierarchy IDs as before.Breaking changes
The
GovernanceStoreinterface has a newuserID stringparameter inCollectApplicableGovernanceIDs. Any external implementations ofGovernanceStoremust be updated to match the new signature.Related issues
Security considerations
No new auth surfaces introduced. The
userIDvalue is sourced from the existing request context and is only used for in-memory sync.Map lookups — no external I/O or privilege escalation risk.Checklist
docs/contributing/README.mdand followed the guidelines