Conversation
Collaborator
Author
Pratham-Mishra04
force-pushed
the
05-15-fix_transports_modified_for_taking_env_from_session
branch
from
e0c5f9e to
5ef8f6c
Compare
danpiths
reviewed
May 15, 2025
danpiths
approved these changes
May 15, 2025
Pratham-Mishra04
force-pushed
the
05-15-fix_transports_modified_for_taking_env_from_session
branch
from
5ef8f6c to
c98f7bc
Compare
Pratham-Mishra04
force-pushed
the
05-15-fix_vertex_ai_provider_cred_input_changes
branch
from
c58ad8c to
763035f
Compare
This was referenced May 17, 2025
Contributor
Merge activity
|
akshaydeo
changed the base branch from
05-15-fix_vertex_ai_provider_cred_input_changes
to
graphite-base/39
akshaydeo
force-pushed
the
05-15-fix_transports_modified_for_taking_env_from_session
branch
from
c98f7bc to
3be2341
Compare
Pratham-Mishra04
deleted the
05-15-fix_transports_modified_for_taking_env_from_session
branch
akshaydeo
added a commit
that referenced
this pull request
Nov 17, 2025
# Remove .env file dependency in favor of environment variables This PR removes the dependency on `.env` files for configuration and instead uses environment variables directly. This simplifies the setup process and aligns with standard container practices. Key changes: - Removed the `-env` flag from the HTTP server command - Updated the Dockerfile to no longer require an ENV_PATH argument - Deleted the `.env.sample` file as it's no longer needed - Modified the `ReadKeys()` function to read directly from the environment instead of a .env file - Removed the godotenv dependency - Updated documentation in README files to reflect the new environment variable approach - Fixed a path in the Dockerfile for building the binary Users now need to set environment variables directly in their shell or pass them to Docker using the `-e` flag rather than creating a separate .env file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove .env file dependency in favor of environment variables
This PR removes the dependency on
.envfiles for configuration and instead uses environment variables directly. This simplifies the setup process and aligns with standard container practices.Key changes:
-envflag from the HTTP server command.env.samplefile as it's no longer neededReadKeys()function to read directly from the environment instead of a .env fileUsers now need to set environment variables directly in their shell or pass them to Docker using the
-eflag rather than creating a separate .env file.