Conversation
Collaborator
Author
Contributor
|
one more thing we would need to add is support for traceId and/or spanId to be passed in headers for distributed tracing - for example, add support for headers
if you find any of these - the generation will be added to the corresponding entity. |
Pratham-Mishra04
force-pushed
the
05-12-fix_maxim_sdk_fixes
branch
from
a91417b to
71cdb98
Compare
Collaborator
Author
|
yes we can do that in http transport |
Pratham-Mishra04
force-pushed
the
05-12-fix_maxim_sdk_fixes
branch
from
71cdb98 to
a9a2cc4
Compare
This was referenced May 14, 2025
Pratham-Mishra04
force-pushed
the
05-12-fix_maxim_sdk_fixes
branch
from
a9a2cc4 to
5688966
Compare
Pratham-Mishra04
force-pushed
the
05-12-fix_maxim_sdk_fixes
branch
from
5688966 to
478a21f
Compare
This was referenced May 17, 2025
akshaydeo
approved these changes
May 18, 2025
Contributor
Merge activity
|
akshaydeo
added a commit
that referenced
this pull request
Nov 17, 2025
# Add JSON tags to Bifrost schemas and enhance Maxim SDK logging This PR enhances the Bifrost codebase in two key areas: 1. Adds JSON struct tags to the Bifrost request and related schemas to ensure proper serialization/deserialization. 2. Significantly improves the Maxim SDK logging plugin: - Replaces timestamp-based trace IDs with UUID-based identifiers - Adds structured logging for different request types (chat vs. text completion) - Captures detailed information about requests including model parameters - Implements proper generation tracking with separate generation IDs - Adds proper trace and generation lifecycle management (ending traces and flushing logs) - Extracts and logs message content in a more structured way The PR also updates the plugins module dependencies to include the Google UUID package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JSON tags to Bifrost schemas and enhance Maxim SDK logging
This PR enhances the Bifrost codebase in two key areas:
Adds JSON struct tags to the Bifrost request and related schemas to ensure proper serialization/deserialization.
Significantly improves the Maxim SDK logging plugin:
The PR also updates the plugins module dependencies to include the Google UUID package.