Skip to content

refactor: use auth credentials directly instead of file path for Vertex provider#38

Merged
akshaydeo merged 1 commit intomainfrom
05-15-fix_vertex_ai_provider_cred_input_changes
May 18, 2025
Merged

refactor: use auth credentials directly instead of file path for Vertex provider#38
akshaydeo merged 1 commit intomainfrom
05-15-fix_vertex_ai_provider_cred_input_changes

Conversation

@Pratham-Mishra04
Copy link
Copy Markdown
Collaborator

Use Vertex credentials directly instead of reading from file

This PR changes the Vertex provider to accept authentication credentials directly as a string rather than reading them from a file path. This simplifies configuration and deployment by:

  1. Replacing auth_credential_path with auth_credentials in the Vertex meta configuration
  2. Modifying the provider interface to use GetAuthCredentials() instead of GetAuthCredentialPath()
  3. Updating the Vertex provider to use the credentials directly instead of reading from a file
  4. Updating test configurations and example config to use the new approach

This change allows credentials to be passed directly as environment variables or configuration values without requiring file system access.

@Pratham-Mishra04 Pratham-Mishra04 changed the base branch from main to graphite-base/38 May 17, 2025 05:44
@Pratham-Mishra04 Pratham-Mishra04 force-pushed the 05-15-fix_vertex_ai_provider_cred_input_changes branch from c58ad8c to 763035f Compare May 17, 2025 05:44
@Pratham-Mishra04 Pratham-Mishra04 changed the base branch from graphite-base/38 to 05-13-feat_readme_additions May 17, 2025 05:44
@Pratham-Mishra04 Pratham-Mishra04 requested a review from danpiths May 17, 2025 05:44
Copy link
Copy Markdown
Contributor

akshaydeo commented May 18, 2025

Merge activity

  • May 18, 5:42 PM GMT+5:30: A user started a stack merge that includes this pull request via Graphite.
  • May 18, 5:49 PM GMT+5:30: Graphite rebased this pull request as part of a merge.
  • May 18, 5:51 PM GMT+5:30: @akshaydeo merged this pull request with Graphite.

@akshaydeo akshaydeo changed the base branch from 05-13-feat_readme_additions to graphite-base/38 May 18, 2025 12:16
@akshaydeo akshaydeo changed the base branch from graphite-base/38 to main May 18, 2025 12:18
@akshaydeo akshaydeo force-pushed the 05-15-fix_vertex_ai_provider_cred_input_changes branch from 763035f to e9e8a5f Compare May 18, 2025 12:19
@akshaydeo akshaydeo merged commit 340b353 into main May 18, 2025
1 check passed
@Pratham-Mishra04 Pratham-Mishra04 deleted the 05-15-fix_vertex_ai_provider_cred_input_changes branch May 18, 2025 18:06
akshaydeo added a commit that referenced this pull request Nov 17, 2025
…ex provider (#38)

# Use Vertex credentials directly instead of reading from file

This PR changes the Vertex provider to accept authentication credentials directly as a string rather than reading them from a file path. This simplifies configuration and deployment by:

1. Replacing `auth_credential_path` with `auth_credentials` in the Vertex meta configuration
2. Modifying the provider interface to use `GetAuthCredentials()` instead of `GetAuthCredentialPath()`
3. Updating the Vertex provider to use the credentials directly instead of reading from a file
4. Updating test configurations and example config to use the new approach

This change allows credentials to be passed directly as environment variables or configuration values without requiring file system access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants