Remove check for client secret length#419
Merged
mickmister merged 5 commits intomasterfrom Jan 17, 2024
Merged
Conversation
mickmister
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #419 +/- ##
=======================================
Coverage 33.40% 33.40%
=======================================
Files 22 22
Lines 3979 3979
=======================================
Hits 1329 1329
Misses 2519 2519
Partials 131 131 ☔ View full report in Codecov by Sentry. |
mickmister
commented
Dec 14, 2023
hanzei
requested changes
Dec 14, 2023
Collaborator
hanzei
left a comment
hanzei
left a comment
There was a problem hiding this comment.
Relaxing the validation is fine, but there should some minimal checks
hanzei
reviewed
Dec 14, 2023
hanzei
approved these changes
Dec 18, 2023
Contributor
Author
|
/update-branch |
mickmister
added
4: Reviews Complete
This was referenced Jan 24, 2024
Closed
raghavaggarwal2308
pushed a commit
to Brightscout/mattermost-plugin-gitlab
that referenced
this pull request
Feb 14, 2024
* support client secrets longer than 64 chars * remove length check * change client secret length check to assume at least 64 chars * change wording of error message
Merged
mickmister
added a commit
that referenced
this pull request
Feb 20, 2024
* Remove check for client secret length (#419) * support client secrets longer than 64 chars * remove length check * change client secret length check to assume at least 64 chars * change wording of error message * [GH-321]:Fixed issue #321 'Wrong notification in case of assigned prs' (#395) Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com> * [MI-3405] Fix issues #271: Sidebar header MR count should show assigned MRs instead of opened MRs (#39) (#394) * [MI-3405] Get proper data in sidebar buttons: 1. Get assigned PRs instead of the user's PRs. 2. Updated the name of sidebar buttons. 3. Updated API path. 4. Updated the name of API functions. 5. Updated the name of unreads to todos in the code. * [MI-3405] Updated name of variables and functions * [MI-3405] Updated icons in sidebar * [MI-3405] Updated documentation * [MI-3405] Reverted package-lock file changes * [MI-3405] Review fixes * [MM-42] Fix CI error: implicit memory aliasing (#429) * [MI-3588] Fix issue: Image attachment breaking in comment notification (#406) * [MI-3719] Send the users an ephemeral message if they try to connect their account via MM desktop app (#416) * [MI-3719] Send the users an ephemeral message if they try to connect their account via MM desktop app * [MI-3713] Handles the following cases as well for desktop app: 1. Connecting using the button from the teams sidebar. 2. Connecting using the button from RHS. * [MI-3719] Review fixes * [MI-3719] Review fixes Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * [MI-3719] Fix lint error --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Fix lint errors * Update plugin version --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: kshitij katiyar <90389917+Kshitij-Katiyar@users.noreply.github.com> Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
According to #412, GitLab is now providing client secrets greater than 64 characters. This PR makes it so we don't check the length anymore. The requirements in the external system could change at any point, so we should probably leave that validation out of our system.
Ticket Link
Fixes #412