Release bump 1.8.1#460
Merged
mickmister merged 8 commits intomattermost:release-1.8.1from Feb 20, 2024
Merged
Conversation
* support client secrets longer than 64 chars * remove length check * change client secret length check to assume at least 64 chars * change wording of error message
…case of assigned prs' (mattermost#395) Co-authored-by: Abhishek Verma <abhishek.verma@brightscout.com> Co-authored-by: ayusht2810 <ayush.thakur@brightscout.com>
…how assigned MRs instead of opened MRs (#39) (mattermost#394) * [MI-3405] Get proper data in sidebar buttons: 1. Get assigned PRs instead of the user's PRs. 2. Updated the name of sidebar buttons. 3. Updated API path. 4. Updated the name of API functions. 5. Updated the name of unreads to todos in the code. * [MI-3405] Updated name of variables and functions * [MI-3405] Updated icons in sidebar * [MI-3405] Updated documentation * [MI-3405] Reverted package-lock file changes * [MI-3405] Review fixes
…their account via MM desktop app (mattermost#416) * [MI-3719] Send the users an ephemeral message if they try to connect their account via MM desktop app * [MI-3713] Handles the following cases as well for desktop app: 1. Connecting using the button from the teams sidebar. 2. Connecting using the button from RHS. * [MI-3719] Review fixes * [MI-3719] Review fixes Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * [MI-3719] Fix lint error --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
raghavaggarwal2308
requested review from
mickmister and
spirosoik
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-1.8.1 #460 +/- ##
=================================================
+ Coverage 33.57% 33.71% +0.14%
=================================================
Files 22 22
Lines 3929 3945 +16
=================================================
+ Hits 1319 1330 +11
- Misses 2479 2482 +3
- Partials 131 133 +2 ☔ View full report in Codecov by Sentry. |
Contributor
|
Note that this branch does not have the changes from #451, so we'll need to manually set the version number in |
mickmister
approved these changes
Feb 16, 2024
mickmister
added
2: Dev Review
Author
|
@mickmister Updated version in plugin.json |
AayushChaudhary0001
approved these changes
Feb 19, 2024
AayushChaudhary0001
left a comment
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
The above PR has been tested for the following scenarios:-
- Assigned MR's instead of opened MR's
- No notification for commits on MR's
- Notification in case of assignee changed to the new assignee assigned.
- Image support in comment notification
- Ephemeral message to the user in desktop app
- Basic slash commands, notifications, LHS action icons and RHS
The PR was working fine for all the above scenarios, LGTM. Approved.
hanzei
added
4: Reviews Complete
hanzei
approved these changes
Feb 19, 2024
mickmister
approved these changes
Feb 20, 2024
| @@ -6,7 +6,7 @@ | |||
| "support_url": "https://github.com/mattermost/mattermost-plugin-gitlab/issues", | |||
| "release_notes_url": "https://github.com/mattermost/mattermost-plugin-gitlab/releases/tag/v1.8.0", | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "release_notes_url": "https://github.com/mattermost/mattermost-plugin-gitlab/releases/tag/v1.8.0", | |
| "release_notes_url": "https://github.com/mattermost/mattermost-plugin-gitlab/releases/tag/v1.8.1", |
Contributor
There was a problem hiding this comment.
We can change this in marketplace PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes