Skip to content

Remove check for client secret length #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickmister merged 5 commits into from
Jan 17, 2024
Merged

Remove check for client secret length #419

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3144425
support client secrets longer than 64 chars
mickmister Dec 13, 2023
05d33c4
remove length check
mickmister Dec 13, 2023
ea80b0d
change client secret length check to assume at least 64 chars
mickmister Dec 14, 2023
0e38b4e
change wording of error message
mickmister Dec 14, 2023
cf308d3
Merge branch 'master' into client-secret-length
mickmister Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions server/flow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,8 +509,8 @@ func (fm *FlowManager) submitOAuthConfig(f *flow.Flow, submitted map[string]inte

clientID = strings.TrimSpace(clientID)

if len(clientID) != 64 {
errorList["client_id"] = "Client ID should be 64 characters long"
if len(clientID) < 64 {
errorList["client_id"] = "Client ID should be at least 64 characters long"
}

clientSecretRaw, ok := submitted["client_secret"]
Expand All @@ -524,8 +524,8 @@ func (fm *FlowManager) submitOAuthConfig(f *flow.Flow, submitted map[string]inte

clientSecret = strings.TrimSpace(clientSecret)

if len(clientSecret) != 64 {
errorList["client_secret"] = "Client Secret should be 64 characters long"
if len(clientSecret) < 64 {
errorList["client_secret"] = "Client Secret should be at least 64 characters long"
}

if len(errorList) != 0 {
Expand Down