[GH-400] Display proper message for access request todo#404
Merged
mickmister merged 2 commits intomattermost:masterfrom Nov 28, 2023
Merged
[GH-400] Display proper message for access request todo#404mickmister merged 2 commits intomattermost:masterfrom
mickmister merged 2 commits intomattermost:masterfrom
Conversation
* [MI-3515] Display proper message for access request todo * [MI-3515] Review fix
raghavaggarwal2308
requested review from
mickmister and
spirosoik
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #404 +/- ##
==========================================
- Coverage 32.91% 32.86% -0.05%
==========================================
Files 22 22
Lines 4017 4022 +5
==========================================
Hits 1322 1322
- Misses 2564 2569 +5
Partials 131 131
☔ View full report in Codecov by Sentry. |
mickmister
approved these changes
Sep 26, 2023
Author
|
@mickmister Fixed the review comments mentioned by you. |
mickmister
approved these changes
Sep 27, 2023
AayushChaudhary0001
approved these changes
Nov 28, 2023
AayushChaudhary0001
left a comment
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
Tested and approved, LGTM
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The description of the "member_access_requested" todo was not being displayed, we handled the case specifically and added a proper description.
Screenshots
Earlier:
Now:
What to test:
Steps to reproduce:
/gitlab todocommand on Mattermost. You should get a post containing the todos.Expected behavior:
Environment:
GitLab Plugin version: 1.7.0
MM version: v7.8.2
Ticket Link
Fixes #400