Skip to content

[GH-400] Display proper message for access request todo #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mickmister merged 2 commits into from
Nov 28, 2023
Merged

[GH-400] Display proper message for access request todo #404

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83afded
[MI-3515] Display proper message for access request todo (#41)
Sep 22, 2023
3fa37a3
Fixed names and messages
Sep 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions server/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,9 @@ const (
SettingReminders = "reminders"
SettingOn = "on"
SettingOff = "off"
chimeraGitLabAppIdentifier = "plugin-gitlab"
Comment thread
raghavaggarwal2308 marked this conversation as resolved.
Outdated

chimeraGitLabAppIdentifier = "plugin-gitlab"
ActionNameMemberAccessRequest = "member_access_requested"
Comment thread
raghavaggarwal2308 marked this conversation as resolved.
Outdated

invalidTokenError = "401 {error: invalid_token}" //#nosec G101 -- False positive
)
Expand Down Expand Up @@ -606,7 +607,14 @@ func (p *Plugin) GetToDo(ctx context.Context, user *gitlab.UserInfo) (bool, stri
continue
}
notificationCount++
notificationContent += fmt.Sprintf("* %v : [%v](%v)\n", n.ActionName, n.Target.Title, n.TargetURL)

switch n.ActionName {
// Handling this cases specifically as the "Title" field is empty in this case
Comment thread
raghavaggarwal2308 marked this conversation as resolved.
Outdated
case ActionNameMemberAccessRequest:
notificationContent += fmt.Sprintf("* %v : [%v](%v) has requested access to [%v](%v)\n", n.ActionName, n.Author.Name, n.Author.WebURL, n.Body, n.TargetURL)
default:
notificationContent += fmt.Sprintf("* %v : [%v](%v)\n", n.ActionName, n.Target.Title, n.TargetURL)
}
}

if notificationCount == 0 {
Expand Down