[GH-383] Fix UX for member_access_request in right hand sidebar#407
Merged
mickmister merged 2 commits intomattermost:masterfrom Nov 28, 2023
Merged
[GH-383] Fix UX for member_access_request in right hand sidebar#407mickmister merged 2 commits intomattermost:masterfrom
mickmister merged 2 commits intomattermost:masterfrom
Conversation
* [MI-3567] Fix UX for member_access_request in right hand sidebar * [MI-3567] Review fixes * [MI-3567] Added a semicolon * [MI-3567] Review fixes
raghavaggarwal2308
requested review from
mickmister and
spirosoik
as code owners
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
=======================================
Coverage 32.91% 32.91%
=======================================
Files 22 22
Lines 4017 4017
=======================================
Hits 1322 1322
Misses 2564 2564
Partials 131 131 ☔ View full report in Codecov by Sentry. |
mickmister
reviewed
Oct 10, 2023
Author
|
@mickmister Fixed the review comments mentioned by you |
mickmister
approved these changes
Oct 10, 2023
AayushChaudhary0001
approved these changes
Nov 28, 2023
AayushChaudhary0001
left a comment
AayushChaudhary0001
left a comment
There was a problem hiding this comment.
Tested and approved. LGTM
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/gitlab todocommand.Screenshots
What to test?
Steps to reproduce:
Environment:
MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0
Ticket Link
Fixes #383