Skip to content

Label the "embed video inside Mattermost" feature as experimental in '/jitsi help'#127

Closed
jasonblais wants to merge 1 commit intomasterfrom
jasonblais-patch-1
Closed

Label the "embed video inside Mattermost" feature as experimental in '/jitsi help'#127
jasonblais wants to merge 1 commit intomasterfrom
jasonblais-patch-1

Conversation

@jasonblais
Copy link
Copy Markdown
Contributor

Proposing adding the label given there are a few outstanding issues with this feature, e.g. #122

It is already noted as experimental in the System Console.

…/jitsi settings

Proposing adding the label given there are a few outstanding issues with this feature.

It is already noted as experimental in the System Console.
@jasonblais jasonblais added this to the v2.0.0 milestone Jun 27, 2020
@jasonblais jasonblais requested a review from jespino June 27, 2020 19:04
@jasonblais jasonblais changed the title Label the "embed video inside Mattermost" feature as experimental in /jitsi settings Label the "embed video inside Mattermost" feature as experimental in '/jitsi help' Jun 27, 2020
@jasonblais jasonblais added the 2: Dev Review Requires review by a core committer label Jun 27, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   44.03%   44.03%           
=======================================
  Files           8        8           
  Lines         822      822           
=======================================
  Hits          362      362           
  Misses        433      433           
  Partials       27       27           
Impacted Files Coverage Δ
server/command.go 72.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3656289...cfd6d92. Read the comment docs.

@jespino
Copy link
Copy Markdown
Contributor

jespino commented Jun 29, 2020

@hanzei can you verify that the german translation is ok?

@jespino jespino requested a review from hanzei June 29, 2020 11:03
@jespino
Copy link
Copy Markdown
Contributor

jespino commented Jun 29, 2020

For some weird reason hasn't take my changes (at least in the interface of github).

@jespino jespino closed this Jun 29, 2020
@jespino
Copy link
Copy Markdown
Contributor

jespino commented Jun 29, 2020

Closed and replaced with #128

ayusht2810 pushed a commit that referenced this pull request Feb 14, 2024
#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
mickmister added a commit that referenced this pull request Feb 15, 2024
* Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (#192)

* Revert "Update main.go (#154)"

This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475.

* Revert "[MM-33506] Use embed package to include plugin manifest (#145)"

This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f.

* Revert "Don't generate manifest.ts (#127)"

This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e.

* install-go-tools target, adopt gotestsum

* bring back make apply + automatic versioning

* Update build/manifest/main.go

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* suppress git describe error when no tags match

* make version/release notes opt-in

* fix whitespace in Makefile

* document version management options

---------

Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>

* Fetch plugin logs from server (#193)

Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>

---------

Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com>
Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants