Merged
Conversation
larkox
approved these changes
Jun 15, 2021
Contributor
larkox
left a comment
larkox
left a comment
There was a problem hiding this comment.
Apart of the linting issues, LGTM.
larkox
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #192 +/- ##
=======================================
Coverage 44.95% 44.95%
=======================================
Files 7 7
Lines 803 803
=======================================
Hits 361 361
Misses 417 417
Partials 25 25 Continue to review full report at Codecov.
|
Contributor
|
@hanzei I think for these PRs we agreed QA testing happens prior to cutting a release, to make the QA load lighter? |
Contributor
|
If @DHaussermann agrees with that, I'm fine with merging the PR without QA testing. |
Contributor
|
Yes, that is what we agreed on the call with Demansol last week, but I can confirm with Dylan as well |
DHaussermann
approved these changes
Jun 17, 2021
DHaussermann
left a comment
DHaussermann
left a comment
There was a problem hiding this comment.
Yes, let's merge this.
I will regression test before the next Jitsi release.
Thanks @maisnamrajusingh for this contribution.
hanzei
added
4: Reviews Complete
Merged
ayusht2810
pushed a commit
that referenced
this pull request
Feb 14, 2024
#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com>
mickmister
added a commit
that referenced
this pull request
Feb 15, 2024
* Sync with playbooks: install-go-tools, gotestsum, and dynamic versions (#192) * Revert "Update main.go (#154)" This reverts commit be4a281d0cc791d10e6e5ae917b325b2f054e475. * Revert "[MM-33506] Use embed package to include plugin manifest (#145)" This reverts commit ca9ee3c17c6920a636a33f378e17395afd6f329f. * Revert "Don't generate manifest.ts (#127)" This reverts commit 18d30b50bc7ba800c9f05bfd82970781db0aea3e. * install-go-tools target, adopt gotestsum * bring back make apply + automatic versioning * Update build/manifest/main.go Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * suppress git describe error when no tags match * make version/release notes opt-in * fix whitespace in Makefile * document version management options --------- Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> * Fetch plugin logs from server (#193) Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> --------- Co-authored-by: Jesse Hallam <jesse.hallam@gmail.com> Co-authored-by: Michael Kochell <6913320+mickmister@users.noreply.github.com> Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes the spacing issue
Ticket Link
Fixes #165