Skip to content

Jasonblais patch 1 updated#128

Merged
hanzei merged 5 commits intomasterfrom
jasonblais-patch-1-updated
Jun 29, 2020
Merged

Jasonblais patch 1 updated#128
hanzei merged 5 commits intomasterfrom
jasonblais-patch-1-updated

Conversation

@jespino
Copy link
Copy Markdown
Contributor

@jespino jespino commented Jun 29, 2020

Proposing adding the label given there are a few outstanding issues with this feature, e.g. #122

It is already noted as experimental in the System Console.

This is to replace #127 because a problem with github taking the changes.

jasonblais and others added 2 commits June 27, 2020 15:04
…/jitsi settings

Proposing adding the label given there are a few outstanding issues with this feature.

It is already noted as experimental in the System Console.
@jespino jespino requested a review from hanzei June 29, 2020 11:12
@jespino
Copy link
Copy Markdown
Contributor Author

jespino commented Jun 29, 2020

@hanzei can you confirm the german translation here?

Copy link
Copy Markdown
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost 😉

Comment thread assets/i18n/active.de.json Outdated
jespino and others added 3 commits June 29, 2020 13:47
Co-authored-by: Ben Schumacher <ben.schumacher@mattermost.com>
@hanzei hanzei added the 4: Reviews Complete All reviewers have approved the pull request label Jun 29, 2020
@hanzei hanzei added this to the v2.0.0 milestone Jun 29, 2020
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   44.03%   44.03%           
=======================================
  Files           8        8           
  Lines         822      822           
=======================================
  Hits          362      362           
  Misses        433      433           
  Partials       27       27           
Impacted Files Coverage Δ
server/command.go 72.48% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3656289...7a250d3. Read the comment docs.

@hanzei hanzei merged commit bf18efe into master Jun 29, 2020
@hanzei hanzei deleted the jasonblais-patch-1-updated branch June 29, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants