This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Switch to yarn for dependency management
#2773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have changed our release scripts to commit changes to lock files during release, so it should be safe to allow them again.
For the React SDK, we did not commit npm lock files, so there is no correct copy to import from. For this repo, I created a fresh yarn lock file using yarn install.
Most `npm` operations are replaced with `yarn`, which generally has better behavior. However, steps like publish that write to the NPM registry are left to `npm`, which currently handles these tasks best.
This avoids the deprecation warning about `prepublish` scripts. It should not change when the script is run.
Take advantage of Yarn's preservation of links while installing and set up links first and install second. This should result in a small speedup since we no longer install the published SDKs just to replace them on the next line.
|
This looks to be passing on Travis and I verified that |
turt2live
approved these changes
Mar 12, 2019
| @@ -14,6 +14,3 @@ npm-debug.log | |||
| /src/component-index.js | |||
|
|
|||
| .DS_Store | |||
|
|
|||
| # https://github.com/vector-im/riot-web/issues/7083 | |||
| package-lock.json | |||
There was a problem hiding this comment.
something I encountered while breaking my local environment was that a yarn-error.log can be created. We should ignore that at all 3 levels.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
npmoperations are replaced withyarn, which generally has betterbehavior. However, steps like publish that write to the NPM registry are left to
npm, which currently handles these tasks best.Part of element-hq/element-web#7756
Previously reviewed portion for JS SDK: matrix-org/matrix-js-sdk#856