Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to yarn for dependency management #856

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Mar 8, 2019

Most npm operations are replaced with yarn, which generally has better
behavior. However, steps like publish that write to the NPM registry are left to
npm, which currently handles these tasks best.

Part of element-hq/element-web#7756

The npm lock file was imported into yarn. A yarn install pass was then run to
double-check the lock file for sanity.
Most `npm` operations are replaced with `yarn`, which generally has better
behavior. However, steps like publish that write to the NPM registry are left to
`npm`, which currently handles these tasks best.
travis.sh Outdated Show resolved Hide resolved
This gives more natural behavior of downloading Olm by default when working on
this module, so that all tests including crypto are run.
@jryans jryans requested a review from a team March 8, 2019 16:17
@jryans
Copy link
Collaborator Author

jryans commented Mar 8, 2019

Assuming this conversion approach looks good for JS SDK, I'll open PRs for the other two repos as well. (There's no particular need to merge them all at the same time.)

@turt2live turt2live requested review from turt2live and removed request for turt2live March 8, 2019 18:11
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally lgtm, but maybe another pair of 👀 wouldn't be bad for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants