Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to yarn for dependency management #9132

Merged
merged 3 commits into from
Mar 13, 2019
Merged

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Mar 12, 2019

Most npm operations are replaced with yarn, which generally has better
behavior. However, steps like publish that write to the NPM registry are left to
npm, which currently handles these tasks best.

Part of #7756

Previously reviewed portion for JS SDK: matrix-org/matrix-js-sdk#856
Under review portion for React SDK: matrix-org/matrix-react-sdk#2773

The npm lock file was imported into yarn. A yarn install pass was then run to
double-check the lock file for sanity.
We did not previously commit lock files for the Electron app, so there is no
correct copy to import from. For this directory, I created a fresh yarn lock
file using yarn install.
Most `npm` operations are replaced with `yarn`, which generally has better
behavior. However, steps like publish that write to the NPM registry are left to
`npm`, which currently handles these tasks best.
@jryans jryans requested a review from a team March 12, 2019 11:24
@turt2live turt2live self-requested a review March 12, 2019 18:27
@jryans jryans merged commit 1abaf50 into element-hq:develop Mar 13, 2019
@jryans jryans mentioned this pull request Mar 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants