-
-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement tables.list and tables.delete RPC APIs on the schema page #3651
Conversation
fbd1c84
to
9beaa5e
Compare
36eb38b
to
fb85ec0
Compare
872a7ef
to
511c462
Compare
511c462
to
ca7340b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seancolsen I scanned through the code and it looks fine.
However, I'm not able to get tables to list on the UI while testing.
Request:
{
"jsonrpc":"2.0",
"id":0,
"method":"tables.list_with_metadata",
"params": {
"database_id":1,
"schema_oid":2200
}
}
Response:
{
"id": 0,
"jsonrpc": "2.0",
"error": {
"code": -31049,
"message": "TypeError: 'NoneType' object is not iterable"
}
}
I assume this is because I do not have any metadata and somewhere in the backend it's trying to read and merge a non-existent metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seancolsen Looks good to me!
As discussed over call, we could merge this PR after resolving the conflicts here once #3710 is merged.
This PR implements the following RPC methods on the schema page, making it possible to list tables, delete tables, and patch tables.
/api/db/v0/tables/
tables.list
/api/db/v0/tables/{tableId}/
tables.delete
/api/db/v0/tables/{tableId}/
tables.patch
I'll handle creating tables in a separate PR.
Checklist
Update index.md
).develop
branch of the repositoryDeveloper Certificate of Origin
Developer Certificate of Origin