Homepage changes - Modify Connections to Databases

[pavish]

Related to #3687

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the develop branch of the repository
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no
  visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[seancolsen]

This looks great! Nice work on this. I feel like databases.ts is basically exactly as I would have written it. Cool!

I don't have any concerns with the work in this PR, but I do have one question regarding what follows this:

• I notice a few things together which make me curious:

  • The Database type has server_id instead of host and port properties.
  • We have a separate Server type
  • When call api.database_setup RPC methods, we are currently discarding the server property returned from the API.

  This makes me wonder how you're planning to persist that server data in the front end in order to display it. The impression I get is that you're planning to have a separate ServersStore. Is that right? This is the kind of architectural stuff that I think would be nice to sync up about somehow before you launch into coding. If you could lay out a rough outline of how you want these stores to work on the front end, I think it would be really helpful for us both to make sure we're on the same page about the plans. The DatabasesStore looks great as it is on its own. But I'd like the opportunity to give input on the larger stores structure before you get so far along that making large structural changes becomes difficult.