Implement tables.list and tables.delete RPC APIs on the schema page

mathesar_ui/src/api/rest/columns.ts

@@ -1,8 +1,7 @@
-import type { TableEntry } from './types/tables';
 import type { Column } from './types/tables/columns';
 import { type PaginatedResponse, getAPI } from './utils/requestUtils';
 
-function list(tableId: TableEntry['id']) {
+function list(tableId: number) {
   const url = `/api/db/v0/tables/${tableId}/columns/?limit=500`;
   return getAPI<PaginatedResponse<Column>>(url);
 }

mathesar_ui/src/api/rest/types/tables/joinable_tables.ts

@@ -4,7 +4,7 @@
  * endpoint: /api/db/v0/tables/<table_id>/joinable_tables/
  */
 
-import type { TableEntry } from '@mathesar/api/rest/types/tables';
+import type { Table } from '@mathesar/api/rpc/tables';
 
 import type { Column } from './columns';
 
@@ -13,7 +13,7 @@ type IsLinkReversed = boolean;
 export type JpPath = [Column['id'], Column['id']][];
 
 export interface JoinableTable {
-  target: TableEntry['id']; // baseTableId
+  target: Table['oid']; // baseTableId
   jp_path: JpPath;
   fk_path: [ForeignKeyId, IsLinkReversed][];
   depth: number;
@@ -25,7 +25,7 @@ export interface JoinableTablesResult {
   tables: Record<
     string, // tableId
     {
-      name: TableEntry['name'];
+      name: Table['name'];
       columns: Column['id'][];
     }
   >;

mathesar_ui/src/api/rpc/index.ts

@@ -4,6 +4,7 @@ import { buildRpcApi } from '@mathesar/packages/json-rpc-client-builder';
 
 import { connections } from './connections';
 import { schemas } from './schemas';
+import { tables } from './tables';
 
 /** Mathesar's JSON-RPC API */
 export const api = buildRpcApi({
@@ -12,5 +13,6 @@ export const api = buildRpcApi({
   methodTree: {
     connections,
     schemas,
+    tables,
   },
 });

mathesar_ui/src/api/rpc/tables.ts

@@ -0,0 +1,90 @@
+import { rpcMethodTypeContainer } from '@mathesar/packages/json-rpc-client-builder';
+
+export interface RawTable {
+  oid: number;
+  name: string;
+  /** The OID of the schema containing the table */
+  schema: number;
+  description: string | null;
+}
+
+interface TableMetadata {
+  import_verified: boolean | null;
+  column_order: number[] | null;
+  record_summary_customized: boolean | null;
+  record_summary_template: string | null;
+}
+
+export interface Table extends RawTable {
+  metadata: TableMetadata | null;
+}
+
+export const tables = {
+  list: rpcMethodTypeContainer<
+    {
+      database_id: number;
+      schema_oid: number;
+    },
+    RawTable[]
+  >(),
+
+  list_with_metadata: rpcMethodTypeContainer<
+    {
+      database_id: number;
+      schema_oid: number;
+    },
+    Table[]
+  >(),
+
+  get: rpcMethodTypeContainer<
+    {
+      database_id: number;
+      table_oid: number;
+    },
+    RawTable
+  >(),
+
+  get_with_metadata: rpcMethodTypeContainer<
+    {
+      database_id: number;
+      table_oid: number;
+    },
+    Table
+  >(),
+
+  /** Returns the oid of the table created */
+  add: rpcMethodTypeContainer<
+    {
+      database_id: number;
+      schema_oid: number;
+      table_name?: string;
+      comment?: string;
+      /** TODO */
+      column_data_list?: unknown;
+      /** TODO */
+      constraint_data_list?: unknown;
+    },
+    number
+  >(),
+
+  patch: rpcMethodTypeContainer<
+    {
+      database_id: number;
+      table_oid: number;
+      table_data_dict: {
+        name?: string;
+        description?: string | null;
+      };
+    },
+    void
+  >(),
+
+  delete: rpcMethodTypeContainer<
+    {
+      database_id: number;
+      table_oid: number;
+      cascade?: boolean;
+    },
+    void
+  >(),
+};

mathesar_ui/src/components/AppHeader.svelte

@@ -56,9 +56,9 @@
       return;
     }
     isCreatingNewEmptyTable = true;
-    const tableInfo = await createTable(database, schema, {});
+    const tableOid = await createTable(database, schema, {});
     isCreatingNewEmptyTable = false;
-    router.goto(getTablePageUrl(database.id, schema.oid, tableInfo.id), false);
+    router.goto(getTablePageUrl(database.id, schema.oid, tableOid), false);
   }
 </script>
 

mathesar_ui/src/components/SelectTable.svelte

@@ -1,27 +1,26 @@
 <script lang="ts">
   import { _ } from 'svelte-i18n';
 
-  import type { TableEntry } from '@mathesar/api/rest/types/tables';
+  import type { Table } from '@mathesar/api/rpc/tables';
   import { Select } from '@mathesar-component-library';
   import type { SelectProps } from '@mathesar-component-library/types';
 
   import TableName from './TableName.svelte';
 
-  type $$Events = Select<TableEntry | undefined>['$$events_def'];
+  type $$Events = Select<Table | undefined>['$$events_def'];
 
-  export let tables: TableEntry[];
-  export let value: TableEntry | undefined = undefined;
+  export let tables: Table[];
+  export let value: Table | undefined = undefined;
   /** TODO: Discuss, do we need prependBlank? */
   export let prependBlank = false;
-  export let autoSelect: SelectProps<TableEntry | undefined>['autoSelect'] =
-    'first';
+  export let autoSelect: SelectProps<Table | undefined>['autoSelect'] = 'first';
 
   $: tableList = prependBlank ? [undefined, ...tables] : tables;
 </script>
 
 <Select
   options={tableList}
-  valuesAreEqual={(a, b) => a?.id === b?.id}
+  valuesAreEqual={(a, b) => a?.oid === b?.oid}
   {autoSelect}
   bind:value
   on:change

mathesar_ui/src/components/SelectTableWithinCurrentSchema.svelte

@@ -1,14 +1,13 @@
 <script lang="ts">
-  import type { TableEntry } from '@mathesar/api/rest/types/tables';
+  import type { Table } from '@mathesar/api/rpc/tables';
   import { importVerifiedTables } from '@mathesar/stores/tables';
   import type { SelectProps } from '@mathesar-component-library/types';
 
   import SelectTable from './SelectTable.svelte';
 
-  export let value: TableEntry | undefined = undefined;
+  export let value: Table | undefined = undefined;
   export let prependBlank = false;
-  export let autoSelect: SelectProps<TableEntry | undefined>['autoSelect'] =
-    'first';
+  export let autoSelect: SelectProps<Table | undefined>['autoSelect'] = 'first';
 
   $: tables = [...$importVerifiedTables.values()];
 </script>

mathesar_ui/src/components/TableName.svelte

@@ -1,25 +1,22 @@
 <script lang="ts">
   import type { ComponentProps } from 'svelte';
 
-  import type { TableEntry } from '@mathesar/api/rest/types/tables';
+  import type { Table } from '@mathesar/api/rpc/tables';
   import { iconTable } from '@mathesar/icons';
-  import { isTableImportConfirmationRequired } from '@mathesar/utils/tables';
+  import { tableRequiresImportConfirmation } from '@mathesar/utils/tables';
 
   import NameWithIcon from './NameWithIcon.svelte';
 
   interface $$Props extends Omit<ComponentProps<NameWithIcon>, 'icon'> {
-    table: {
-      name: TableEntry['name'];
-      data_files?: TableEntry['data_files'];
-      import_verified?: TableEntry['import_verified'];
-    };
+    table: Pick<Table, 'name'> &
+      Parameters<typeof tableRequiresImportConfirmation>[0];
     isLoading?: boolean;
   }
 
   export let table: $$Props['table'];
   export let isLoading = false;
 
-  $: isNotConfirmed = isTableImportConfirmationRequired(table);
+  $: isNotConfirmed = tableRequiresImportConfirmation(table);
 </script>
 
 <NameWithIcon icon={iconTable} {isLoading} {...$$restProps}>

mathesar_ui/src/components/breadcrumb/BreadcrumbItem.svelte

@@ -68,7 +68,7 @@
       href={getRecordPageUrl(
         item.database.id,
         item.schema.oid,
-        item.table.id,
+        item.table.oid,
         item.record.pk,
       )}
     >

mathesar_ui/src/components/breadcrumb/BreadcrumbRecordSelector.svelte

@@ -1,14 +1,14 @@
 <script lang="ts">
-  import type { TableEntry } from '@mathesar/api/rest/types/tables';
+  import type { Table } from '@mathesar/api/rpc/tables';
   import { iconExpandRight } from '@mathesar/icons';
   import { getRecordSelectorFromContext } from '@mathesar/systems/record-selector/RecordSelectorController';
   import { Button, Icon, iconSearch } from '@mathesar-component-library';
 
   const recordSelector = getRecordSelectorFromContext();
-  export let table: TableEntry;
+  export let table: Table;
 
   function handleClick() {
-    recordSelector.navigateToRecordPage({ tableId: table.id });
+    recordSelector.navigateToRecordPage({ tableId: table.oid });
   }
 </script>
 

mathesar_ui/src/components/breadcrumb/EntitySelector.svelte

@@ -3,16 +3,13 @@
   import { meta } from 'tinro';
 
   import type { QueryInstance } from '@mathesar/api/rest/types/queries';
-  import type { TableEntry } from '@mathesar/api/rest/types/tables';
   import type { Schema } from '@mathesar/api/rpc/schemas';
+  import type { Table } from '@mathesar/api/rpc/tables';
   import type { Database } from '@mathesar/AppTypes';
   import { iconTable } from '@mathesar/icons';
   import { getExplorationPageUrl } from '@mathesar/routes/urls';
   import { queries as queriesStore } from '@mathesar/stores/queries';
-  import {
-    currentTableId,
-    tables as tablesStore,
-  } from '@mathesar/stores/tables';
+  import { currentTableId, currentTables } from '@mathesar/stores/tables';
   import { getLinkForTableItem } from '@mathesar/utils/tables';
 
   import BreadcrumbSelector from './BreadcrumbSelector.svelte';
@@ -26,7 +23,7 @@
   export let schema: Schema;
 
   function makeTableBreadcrumbSelectorItem(
-    table: TableEntry,
+    table: Table,
   ): BreadcrumbSelectorEntryForTable {
     return {
       type: 'table',
@@ -35,7 +32,7 @@
       href: getLinkForTableItem(database.id, schema.oid, table),
       icon: iconTable,
       isActive() {
-        return table.id === $currentTableId;
+        return table.oid === $currentTableId;
       },
     };
   }
@@ -63,11 +60,10 @@
     };
   }
 
-  $: tables = [...$tablesStore.data.values()];
   $: queries = [...$queriesStore.data.values()];
 
   $: selectorData = new Map<string, BreadcrumbSelectorEntry[]>([
-    [$_('tables'), tables.map(makeTableBreadcrumbSelectorItem)],
+    [$_('tables'), $currentTables.map(makeTableBreadcrumbSelectorItem)],
     [$_('explorations'), queries.map(makeQueryBreadcrumbSelectorItem)],
   ]);
 </script>