Skip to content

Ipv4 only network - listen on windows #3590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 22, 2023
Merged

Ipv4 only network - listen on windows #3590

merged 7 commits into from
Feb 22, 2023

Conversation

@Leo-Besancon
Copy link
Member

@Leo-Besancon Leo-Besancon commented Feb 21, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

I was able to test that on a IPv4 only-network on windows, nodes could not bootstrap on my node before.
This PR fixes the default behaviour of windows ([::] only matches to IPv6 addresses, not IPv4, so it failed)

@Leo-Besancon Leo-Besancon linked an issue Feb 21, 2023 that may be closed by this pull request
Port 31244&5 KO for some ipv4 windows host nodes - 33035 OK #2617
Closed
@Leo-Besancon Leo-Besancon marked this pull request as ready for review February 21, 2023 10:35
bilboquet
bilboquet reviewed Feb 22, 2023
View reviewed changes
@Leo-Besancon Leo-Besancon merged commit 1673340 into testnet_20 Feb 22, 2023
@Leo-Besancon Leo-Besancon deleted the test_ipv4_listen_windows branch February 22, 2023 15:59
@Leo-Besancon Leo-Besancon mentioned this pull request Feb 22, 2023
Closed
@AurelienFT AurelienFT mentioned this pull request Feb 27, 2023
Merged
bors bot added a commit that referenced this pull request Mar 1, 2023
@bors @AurelienFT
@Ben-PH @modship @Eitu33 @sydhds @aoudiamoncef
Merge #3489
f01d16a 
3489: Testnet 20 r=AurelienFT a=AurelienFT

Merged in this testnet:

- #3475 
- #3549
- #3562 
- #3462 
- #3492 
- #3502 
- #3495 
- #3556 
- #3511 
- #3498 
- #3566 
- #3557 
- #3576 
- #3579 
- #3507 
- #3585 
- #3587 
- #3580 
- #3590 
- #3549 
- #3455 
- #3601 
- #3602 
- #3606 
- #3588 
- #3603 
- #3554

Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Ben PHL <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: Ben <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: modship <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
@Leo-Besancon Leo-Besancon mentioned this pull request Mar 6, 2023
Merged
7 tasks
@Ben-PH Ben-PH mentioned this pull request Mar 20, 2023
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bilboquet bilboquet bilboquet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Port 31244&5 KO for some ipv4 windows host nodes - 33035 OK

3 participants

@Leo-Besancon @bilboquet