Add client error message on bootstrap rejected because of blacklist/whitelist #3511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This was quickly tested locally and with two physical nodes Results with a simple telnet calls: blacklist: telnet 192.168.1.190 31245
Trying 192.168.1.190...
Connected to 192.168.1.190.
Escape character is '^]'.
?q??-?h?,Gs?S%?`???9????'?Q[?g????T?T"y+>F?^ox?R????{??" IP 192.168.1.190 is blacklisted.Connection closed by foreign host.not in whitelist: telnet 192.168.1.190 31245
Trying 192.168.1.190...
Connected to 192.168.1.190.
Escape character is '^]'.
??S?.
_???;R??M?o?Z?????c? ?t?f??)???cy?a?k?a5?N?f??A?A whitelist exists and the IP 192.168.1.190 is not whitelisted.Connection closed by foreign host. |
Eitu33
reviewed
Feb 13, 2023
aoudiamoncef
force-pushed
the
feature/improve-bootsrap-error
branch
from
5b177fa to
668a498
Compare
Eitu33
reviewed
Feb 13, 2023
Ben-PH
reviewed
Feb 13, 2023
Contributor
|
@aoudiamoncef We can merge without gas costs checks passing for now but the ubuntu CI fails also on unused, please fix before we merge |
Contributor
Author
|
@Eitu33 done 💯 |
Eitu33
approved these changes
Feb 14, 2023
Merged
bors bot
added a commit
that referenced
this pull request
Mar 1, 2023
3489: Testnet 20 r=AurelienFT a=AurelienFT Merged in this testnet: - #3475 - #3549 - #3562 - #3462 - #3492 - #3502 - #3495 - #3556 - #3511 - #3498 - #3566 - #3557 - #3576 - #3579 - #3507 - #3585 - #3587 - #3580 - #3590 - #3549 - #3455 - #3601 - #3602 - #3606 - #3588 - #3603 - #3554 Co-authored-by: AurelienFT <[email protected]> Co-authored-by: Ben PHL <[email protected]> Co-authored-by: Modship <[email protected]> Co-authored-by: Ben <[email protected]> Co-authored-by: Eitu33 <[email protected]> Co-authored-by: Sydhds <[email protected]> Co-authored-by: modship <[email protected]> Co-authored-by: Moncef AOUDIA <[email protected]> Co-authored-by: Moncef AOUDIA <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3292