Skip to content

Replace OpenRPC playground in the readme #3588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2023
Merged

Replace OpenRPC playground in the readme #3588

merged 1 commit into from
Feb 24, 2023

Conversation

@aoudiamoncef
Copy link
Contributor

@aoudiamoncef aoudiamoncef commented Feb 20, 2023 •
edited
Loading

  • document all added functions
  • try in sandbox /simulation/labnet
  • unit tests on the added/changed features
    • make tests compile
    • make tests pass
  • add logs allowing easy debugging in case the changes caused problems
  • if the API has changed, update the API specification

@AurelienFT
Copy link
Contributor

AurelienFT commented Feb 24, 2023

Can we merge this @aoudiamoncef for the next testnet ?

@aoudiamoncef
Copy link
Contributor Author

aoudiamoncef commented Feb 24, 2023

Yes 🙌

@AurelienFT
Copy link
Contributor

AurelienFT commented Feb 24, 2023

I let you press the green button as it's your PR :)

@aoudiamoncef aoudiamoncef merged commit e5c2a37 into testnet_20 Feb 24, 2023
@AurelienFT AurelienFT mentioned this pull request Feb 27, 2023
Merged
bors bot added a commit that referenced this pull request Mar 1, 2023
@bors @AurelienFT
@Ben-PH @modship @Eitu33 @sydhds @aoudiamoncef
Merge #3489
f01d16a 
3489: Testnet 20 r=AurelienFT a=AurelienFT

Merged in this testnet:

- #3475 
- #3549
- #3562 
- #3462 
- #3492 
- #3502 
- #3495 
- #3556 
- #3511 
- #3498 
- #3566 
- #3557 
- #3576 
- #3579 
- #3507 
- #3585 
- #3587 
- #3580 
- #3590 
- #3549 
- #3455 
- #3601 
- #3602 
- #3606 
- #3588 
- #3603 
- #3554

Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Ben PHL <[email protected]>
Co-authored-by: Modship <[email protected]>
Co-authored-by: Ben <[email protected]>
Co-authored-by: Eitu33 <[email protected]>
Co-authored-by: Sydhds <[email protected]>
Co-authored-by: modship <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
Co-authored-by: Moncef AOUDIA <[email protected]>
@Ben-PH Ben-PH mentioned this pull request Mar 20, 2023
Closed
28 tasks
@AurelienFT AurelienFT deleted the feature/replace-playground-in-readme branch May 29, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Leo-Besancon Leo-Besancon Leo-Besancon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aoudiamoncef @AurelienFT @Leo-Besancon