fix: bound aidevops update output to prevent tool buffer overflow #426
Conversation
Replace verbose git pull with quiet pull + filtered commit log summary. Shows up to 20 conventional commits (feat/fix/refactor/perf/docs) and total commit count, keeping output well within 51KB tool buffer limit regardless of update size.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Feb 7 06:11:05 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses the potential for tool buffer overflow during updates by using a quiet git pull and showing a bounded summary of changes. The implementation is solid. I've added one suggestion to improve the clarity of the commit summary output, especially in cases where there are many commits but none match the filter for 'meaningful' changes. Overall, a good fix that improves the robustness of the update process.
| local total_commits | ||
| total_commits=$(git rev-list --count "$old_hash..$new_hash") | ||
| echo "" | ||
| print_info "Changes since $current_version ($total_commits commits):" | ||
| git log --oneline "$old_hash..$new_hash" \ | ||
| | grep -E '^[a-f0-9]+ (feat|fix|refactor|perf|docs):' \ | ||
| | head -20 | ||
| if [[ "$total_commits" -gt 20 ]]; then | ||
| echo " ... and more (run 'git log --oneline' in $INSTALL_DIR for full list)" | ||
| fi |
There was a problem hiding this comment.
The current logic for displaying the commit summary can lead to confusing output. If there are more than 20 total commits but none of them are 'meaningful' (i.e., matching the grep filter), the script will display an empty list followed by an '... and more' message.
To make the output clearer, I suggest counting the meaningful commits first and only displaying the summary and the '... and more' message based on that count. This avoids ambiguity and provides a better user experience.
| local total_commits | |
| total_commits=$(git rev-list --count "$old_hash..$new_hash") | |
| echo "" | |
| print_info "Changes since $current_version ($total_commits commits):" | |
| git log --oneline "$old_hash..$new_hash" \ | |
| | grep -E '^[a-f0-9]+ (feat|fix|refactor|perf|docs):' \ | |
| | head -20 | |
| if [[ "$total_commits" -gt 20 ]]; then | |
| echo " ... and more (run 'git log --oneline' in $INSTALL_DIR for full list)" | |
| fi | |
| local total_commits | |
| total_commits=$(git rev-list --count "$old_hash..$new_hash") | |
| # Count meaningful commits to avoid confusing output if none are found. | |
| # `|| true` prevents script exit if grep finds no matches. | |
| local meaningful_commits_count | |
| meaningful_commits_count=$(git log --oneline "$old_hash..$new_hash" | grep -cE '^[a-f0-9]+ (feat|fix|refactor|perf|docs):' || true) | |
| if [[ "${meaningful_commits_count:-0}" -gt 0 ]]; then | |
| echo "" | |
| print_info "Changes since $current_version ($total_commits commits, $meaningful_commits_count meaningful):" | |
| git log --oneline "$old_hash..$new_hash" \ | |
| | grep -E '^[a-f0-9]+ (feat|fix|refactor|perf|docs):' \ | |
| | head -20 | |
| if [[ "$meaningful_commits_count" -gt 20 ]]; then | |
| echo " ... and more (run 'git log --oneline' in $INSTALL_DIR for full list)" | |
| fi | |
| fi |
…elpers (t135.3) (#433) * chore: mark t139 complete in TODO.md (#427) * chore: mark t135.14 complete in TODO.md (#426) * fix: add SQLite WAL mode + busy_timeout to supervisor, memory, mail helpers (t135.3) Add db() wrapper function to all three helpers that sets busy_timeout=5000ms on every SQLite connection via '.timeout 5000' dot-command. This prevents 'database is locked' errors during concurrent access by parallel agents. Changes per helper: - supervisor-helper.sh: Add db() wrapper, replace 106 sqlite3 calls, add WAL migration in ensure_db() for pre-existing databases - memory-helper.sh: Add db() wrapper, replace 63 sqlite3 calls, add WAL PRAGMA to init_db() and WAL migration in ensure_db() - mail-helper.sh: Add db() wrapper, replace 36 sqlite3 calls, add WAL migration in ensure_db() for pre-existing databases WAL mode is persistent (set once per DB), but busy_timeout is per-connection and must be set each time. The db() wrapper ensures every sqlite3 invocation gets the timeout. Tested: 20/20 concurrent writes succeed with fix vs 9/20 without. * chore: sync version to 2.105.3 across all files
…432) * chore: mark t139 complete in TODO.md (#427) * chore: mark t135.14 complete in TODO.md (#426) * fix: add ShellCheck enforcement to CI code-quality workflow (t135.6.3) - Add ShellCheck lint step to framework-validation job - Enforces error-severity violations that fail the build - Iterates all git-tracked .sh files with gcc output format - Mark t135.6 subtasks complete (t135.6.1/t135.6.2 done in PR #423)
1 participant
Summary
git pullwith--quietpull incmd_update(), then outputs a bounded commit summary (up to 20 conventional commits + total count)Changes
aidevops.sh(cmd_update(), line ~556):old_hashbefore pullgit pull --ff-only origin main --quietto suppress diff statfeat|fix|refactor|perf|docsonly,head -20)TODO.md: Mark t138 completeCloses #398