fix: repair corrupted JSON configs and add CI validation #423
Conversation
- Fix pandoc-config.json.txt: replace corrupted control char key with "paths" - Fix chrome-devtools.json: remove shell code after JSON, fix missing brace - Fix code-quality.yml: .agent typo to .agents, remove non-existent dir refs - Add JSON validation step to CI that fails build on invalid JSON files
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @marcusquinn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the robustness and reliability of the codebase by addressing existing JSON configuration corruption and implementing preventative measures. It rectifies two malformed JSON files, ensuring their proper parsing and functionality. Furthermore, a crucial CI validation step has been introduced to automatically detect and prevent any future invalid JSON configurations from being merged, thereby maintaining data integrity across the project. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🔍 Code Quality Report�[0;35m[MONITOR]�[0m Code Review Monitoring Report �[0;34m[INFO]�[0m Latest Quality Status: �[0;34m[INFO]�[0m Recent monitoring activity: 📈 Current Quality Metrics
Generated on: Sat Feb 7 05:31:05 UTC 2026 Generated by AI DevOps Framework Code Review Monitoring |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively addresses critical JSON parsing issues in configs/mcp-templates/chrome-devtools.json and configs/pandoc-config.json.txt. The changes correctly remove invalid shell code and fix a corrupted key, ensuring the configuration files are valid JSON. The description also mentions the addition of CI validation for JSON files, which is a great proactive measure to prevent similar issues in the future.
I am having trouble creating individual review comments. Click here to see my feedback.
configs/mcp-templates/chrome-devtools.json (15-16)
The lines return 0 and the extraneous closing brace } were invalid JSON syntax appended to the configuration. Removing them correctly restores the file to a valid JSON structure, which is crucial for proper parsing and application functionality.
}configs/pandoc-config.json.txt (5-6)
The JSON key "\n": was corrupted and invalid, causing parsing failures. Replacing it with "paths" is the correct fix, aligning with the expected structure for directory paths within the configuration. This ensures the file is valid JSON and can be processed correctly.
"paths": {
- Add ShellCheck lint step to framework-validation job - Enforces error-severity violations that fail the build - Iterates all git-tracked .sh files with gcc output format - Mark t135.6 subtasks complete (t135.6.1/t135.6.2 done in PR #423)
…432) * chore: mark t139 complete in TODO.md (#427) * chore: mark t135.14 complete in TODO.md (#426) * fix: add ShellCheck enforcement to CI code-quality workflow (t135.6.3) - Add ShellCheck lint step to framework-validation job - Enforces error-severity violations that fail the build - Iterates all git-tracked .sh files with gcc output format - Mark t135.6 subtasks complete (t135.6.1/t135.6.2 done in PR #423)
1 participant
Summary
.agenttypo and remove references to non-existent directories in code-quality.ymlChanges
configs/pandoc-config.json.txt
0x0a) embedded inside a JSON key, producing"\n":instead of a valid key name"paths"(inferred from child keys:input_directory,output_directory,temp_directory,backup_originals)configs/mcp-templates/chrome-devtools.json
return 0and}) appended after the JSON closing brace; missing closing brace forchrome-devtoolsobject.github/workflows/code-quality.yml
.agenttypo (should be.agents), references to non-existent.agents/specanddocs/directories.agents/AGENTS.md), addedexit 1on critical failures*.jsonand*.json.txtfiles tracked by git, failing the build if any are invalidVerification
All 89 JSON files in the repo pass
python3 -m json.toolvalidation after these fixes.Task
Closes t135.4 (P1-A: Fix 2 corrupted JSON config files) from the t135 Codebase Quality Hardening plan.