Skip to content

Navigation native #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Guardiola31337 merged 5 commits into from
Sep 27, 2018
Merged

Navigation native #1336

Guardiola31337 merged 5 commits into from
Sep 27, 2018

Conversation

@Guardiola31337
Copy link
Contributor

@Guardiola31337 Guardiola31337 commented Sep 27, 2018

  • Navigation native 🎉

lit

@Guardiola31337 Guardiola31337 self-assigned this Sep 27, 2018
danesfeder and others added 4 commits September 27, 2018 13:04
@danesfeder
Re-merge initial navigation native integration (#1299)
fbcf4dc 
* Nav Native initial setup

* Integrate more of NavigationStatus

* Update for polling NavigationStatus system instead of triggered by Location

* Add tunnel flag

* Use runnable Date for snapped location / off route

* Add voice instruction from NavigationStatus
@danesfeder
MapboxNavigator Offline Routing Integration (#1300)
c9607df 
* Offline Routing Integration

* add offline route activity, fix offline integration / apis and fix voice instruction milestones being fired off twice
@Guardiola31337 @danesfeder
use snapped location in check faster route, fix voice instructions lo…
65380e2 
…gic, add instruction loader null checks to prevent potential npes and opt-in mocking of final classes/methods and fix voice instruction milestone tests (#1318)
@Guardiola31337 @danesfeder
bump mapbox-navigation-native version to 3.0.0 (#1325)
9a97a80
danesfeder
danesfeder approved these changes Sep 27, 2018
View reviewed changes
Copy link
Contributor

@danesfeder danesfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚢 :shipit:

@Guardiola31337 Guardiola31337 merged commit fb73e53 into master Sep 27, 2018
@kevinkreiser
Copy link
Contributor

kevinkreiser commented Sep 27, 2018

\o/

@danesfeder danesfeder mentioned this pull request Oct 1, 2018
Closed
11 tasks
@kevinkreiser kevinkreiser mentioned this pull request Oct 3, 2018
Closed
@akitchen akitchen mentioned this pull request Oct 8, 2018
Closed
6 tasks
This was referenced Oct 18, 2018
Closed
Closed
@devotaaabel devotaaabel deleted the navigation-native branch January 28, 2019 16:07
abhishek1508 added a commit that referenced this pull request Jan 11, 2022
@abhishek1508
Merge branch 'ak-#5302-use-shields-in-maneuvers' into ak-#1336-#1337-…
c1a271e 
…refactor-exit
abhishek1508 added a commit that referenced this pull request Jan 12, 2022
@abhishek1508
Revert "Merge branch 'ak-#5302-use-shields-in-maneuvers' into ak-#1336-…
6f2438a 
…#1337-refactor-exit"

This reverts commit c1a271e, reversing
changes made to 29618e2.
abhishek1508 added a commit that referenced this pull request Jan 12, 2022
@abhishek1508
Revert "Merge branch 'ak-#5302-use-shields-in-maneuvers' into ak-#1336-…
6793904 
…#1337-refactor-exit"

This reverts commit c1a271e, reversing
changes made to 29618e2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devotaaabel devotaaabel Awaiting requested review from devotaaabel

1 more reviewer

@danesfeder danesfeder danesfeder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Guardiola31337 Guardiola31337

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Guardiola31337 @kevinkreiser @danesfeder