-
Notifications
You must be signed in to change notification settings - Fork 320
Re-merge initial navigation native integration #1299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab0335f to
5af84fa
Compare
Guardiola31337
approved these changes
Sep 18, 2018
Contributor
Guardiola31337
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's re-merge ![]()
danesfeder
added a commit
that referenced
this pull request
Sep 26, 2018
* Nav Native initial setup * Integrate more of NavigationStatus * Update for polling NavigationStatus system instead of triggered by Location * Add tunnel flag * Use runnable Date for snapped location / off route * Add voice instruction from NavigationStatus
danesfeder
added a commit
that referenced
this pull request
Sep 26, 2018
* Nav Native initial setup * Integrate more of NavigationStatus * Update for polling NavigationStatus system instead of triggered by Location * Add tunnel flag * Use runnable Date for snapped location / off route * Add voice instruction from NavigationStatus
Guardiola31337
pushed a commit
that referenced
this pull request
Sep 27, 2018
* Nav Native initial setup * Integrate more of NavigationStatus * Update for polling NavigationStatus system instead of triggered by Location * Add tunnel flag * Use runnable Date for snapped location / off route * Add voice instruction from NavigationStatus
Guardiola31337
pushed a commit
that referenced
this pull request
Sep 27, 2018
* Nav Native initial setup * Integrate more of NavigationStatus * Update for polling NavigationStatus system instead of triggered by Location * Add tunnel flag * Use runnable Date for snapped location / off route * Add voice instruction from NavigationStatus
Guardiola31337
pushed a commit
that referenced
this pull request
Sep 27, 2018
* Nav Native initial setup * Integrate more of NavigationStatus * Update for polling NavigationStatus system instead of triggered by Location * Add tunnel flag * Use runnable Date for snapped location / off route * Add voice instruction from NavigationStatus
danesfeder
added a commit
that referenced
this pull request
Sep 27, 2018
* Nav Native initial setup * Integrate more of NavigationStatus * Update for polling NavigationStatus system instead of triggered by Location * Add tunnel flag * Use runnable Date for snapped location / off route * Add voice instruction from NavigationStatus
Guardiola31337
added a commit
that referenced
this pull request
Sep 27, 2018
* Re-merge initial navigation native integration (#1299) * Nav Native initial setup * Integrate more of NavigationStatus * Update for polling NavigationStatus system instead of triggered by Location * Add tunnel flag * Use runnable Date for snapped location / off route * Add voice instruction from NavigationStatus * MapboxNavigator Offline Routing Integration (#1300) * Offline Routing Integration * add offline route activity, fix offline integration / apis and fix voice instruction milestones being fired off twice * use snapped location in check faster route, fix voice instructions logic, add instruction loader null checks to prevent potential npes and opt-in mocking of final classes/methods and fix voice instruction milestone tests (#1318) * bump mapbox-navigation-native version to 3.0.0 (#1325) * minor missing tweaks (#1335) (#1337)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.