Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update postcss-preset-env to avoid build warnings #361

Closed
wants to merge 1 commit into from

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented May 23, 2023

I've been seeing the following warning in my builds for a while:

┌─────────────────────────────────────────────────────────────────────────────────┐
│                                                                                 │
│   This version of postcss-preset-env is not optimised to work with PostCSS 8.   │
│                Please update to version 7 of PostCSS Preset Env.                │
│                                                                                 │
│                    If you find issues, you can report it at:                    │
│          https://github.com/csstools/postcss-plugins/issues/new/choose          │
│                                                                                 │
└─────────────────────────────────────────────────────────────────────────────────┘

It looks like #320 updated the version of broccoli-postcss from v5 to v6, which then updated PostCSS under the hood from v7 to v8. The postcss-preset-env dependency of this project however was not updated and was still pointing to a version that was causing the above warning.

This PR updates the dependency to the latest version, which is compatible with PostCSS v8. The changelog for the diff is available at https://github.com/csstools/postcss-plugins/blob/main/plugin-packs/postcss-preset-env/CHANGELOG.md. I did not find any breaking changes that would be relevant to this project though, so no code changes on our side were necessary.

@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for ember-cli-notifications ready!

Name Link
🔨 Latest commit 878c91c
🔍 Latest deploy log https://app.netlify.com/sites/ember-cli-notifications/deploys/646fc44a839e34000851946f
😎 Deploy Preview https://deploy-preview-361--ember-cli-notifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Turbo87
Copy link
Contributor Author

Turbo87 commented May 23, 2023

#362 should hopefully resolve the compilation issue...

@Turbo87
Copy link
Contributor Author

Turbo87 commented May 25, 2023

@mansona rebasing fixed the compilation issue :)

@nlepage
Copy link
Contributor

nlepage commented Jul 26, 2023

Hi @mansona
any chance this would be merged and released soon?

@mansona mansona mentioned this pull request Nov 24, 2023
@mansona mansona closed this in #365 Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants