Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum supported Node.js version to v16 (No longer relevant) #362

Merged
merged 2 commits into from
May 23, 2023

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented May 23, 2023

Node.js v12 is no longer officially supported, so it is time to update to at least v14. (see https://github.com/nodejs/release#release-schedule)

@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for ember-cli-notifications ready!

Name Link
🔨 Latest commit 047263d
🔍 Latest deploy log https://app.netlify.com/sites/ember-cli-notifications/deploys/646c87fd776ee8000812b3fa
😎 Deploy Preview https://deploy-preview-362--ember-cli-notifications.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mansona mansona changed the title Update minimum supported Node.js version to v14 Breaking: Update minimum supported Node.js version to v16 May 23, 2023
Copy link
Owner

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mansona mansona merged commit efe41af into mansona:main May 23, 2023
@mansona
Copy link
Owner

mansona commented Nov 24, 2023

So I'm labeling this as "internal" now that the addon has been moved to a v2 addon. The node version you are using no longer influences if you can use this 👍

@mansona mansona changed the title Breaking: Update minimum supported Node.js version to v16 Update minimum supported Node.js version to v16 (No longer relevant) Nov 24, 2023
This was referenced Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants