Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Drop support for Node 10 and Modernize syntax #320

Merged
merged 8 commits into from
Nov 9, 2021
Merged

Breaking: Drop support for Node 10 and Modernize syntax #320

merged 8 commits into from
Nov 9, 2021

Conversation

pichfl
Copy link
Contributor

@pichfl pichfl commented Sep 17, 2021

  • Use native classes (available since 3.6, 3.8 being the earliest version this addon is tested against)
  • Use tagLess components (partially done before)
  • Only install ember-on-modifier if necessary

@pichfl pichfl mentioned this pull request Sep 17, 2021
Closed
@pichfl pichfl force-pushed the modernize branch 2 times, most recently from 32c1f7c to d0fc96c Compare September 17, 2021 15:03
@pichfl
Copy link
Contributor Author

pichfl commented Sep 17, 2021

@mansona I wish I would understand what's happening here.

mansona
mansona requested changes Sep 17, 2021
View reviewed changes
Copy link
Owner

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing 👍

package.json Show resolved Hide resolved
@pichfl pichfl force-pushed the modernize branch 2 times, most recently from 58f56bd to d34f93d Compare November 5, 2021 16:34
@mansona mansona changed the title Modernize syntax Breaking: Drop support for Node 10 and Modernize syntax Nov 5, 2021
@mansona mansona merged commit 681e05a into mansona:master Nov 9, 2021
@pichfl pichfl deleted the modernize branch November 9, 2021 16:16
@Turbo87 Turbo87 mentioned this pull request May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pichfl @mansona