Fix Ctrl+H deleting committed text instead of composing text during IME input by sminamot · Pull Request #790 · manaflow-ai/cmux

sminamot · 2026-03-03T09:31:03Z

Summary

During IME composition (e.g. Japanese input), pressing Ctrl+H deletes already-committed text instead of composing (pre-edit) characters. Backspace key works correctly.

Root cause

The Ctrl key fast path in keyDown (GhosttyTerminalView.swift:3009) unconditionally bypasses interpretKeyEvents() and sends key events directly to Ghostty. This skips the IME entirely, so Ctrl+H is treated as a terminal backspace even during composition.

Adding a hasMarkedText() guard to the fast path condition lets Ctrl+key events fall through to interpretKeyEvents() during IME composition, matching Ghostty upstream behavior.

Test plan

Launch debug build with ./scripts/reload.sh --tag fix-ime-ctrl-h
Open Japanese IME, type hiragana to enter composition state
Press Ctrl+H — composing text is deleted (not committed text)
Without IME composition, Ctrl+H/C/D etc. work as normal terminal shortcuts

Summary by cubic

Fixes Ctrl+H during IME composition by skipping the Ctrl-key fast path when marked text is present, so composing text is deleted instead of committed text. Ctrl+key events now go through interpretKeyEvents() during composition; normal Ctrl shortcuts remain unchanged outside composition.

^{Written for commit 132bc6c. Summary will update on new commits.}

Summary by CodeRabbit

Bug Fixes
- Fixed Ctrl key handling to properly respect input method composition, allowing uninterrupted text entry for users utilizing IME.

During IME composition (e.g. Japanese input), Ctrl+H should delete composing characters via the IME, not bypass it and send a backspace directly to the terminal. Add a hasMarkedText() check so the fast path is only taken when no IME composition is active, letting interpretKeyEvents() handle the key instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

vercel · 2026-03-03T09:31:08Z

@sminamot is attempting to deploy a commit to the Manaflow Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2026-03-03T09:31:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a086ebc and 132bc6c.

📒 Files selected for processing (1)

Sources/GhosttyTerminalView.swift

📝 Walkthrough

Walkthrough

A single-file change to GhosttyTerminalView.swift that adds a guard condition checking hasMarkedText() to both the keyDown and performKeyEquivalent code paths. This prevents Ctrl key input from bypassing IME composition when marked text is present, allowing IME to complete normally.

Changes

Cohort / File(s)	Summary
IME Composition Handling `Sources/GhosttyTerminalView.swift`	Added `hasMarkedText()` guard condition to gate immediate Ghostty key processing in Ctrl key paths (keyDown and performKeyEquivalent), preventing Ctrl input from bypassing IME during composition.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Ctrl+H deletes confirmed characters instead of pre-edit text when using Japanese IME #787: Directly addresses the Ghostty Ctrl-key IME composition bug by gating Ctrl-key processing when IME text is marked.
Shift+Space for Korean IME switching inserts an extra space character #641: Both changes prevent terminal key handlers from bypassing IME by checking IME state before forwarding key events.

Possibly related PRs

Fix Shift+Space IME toggle inserting a space (#641) #670: Modifies the same file (GhosttyTerminalView.swift) with related IME-aware key event handling in keyDown and performKeyEquivalent paths.

Poem

🐰 A Ctrl key caught mid-composition's dance,
Now pauses for the IME's rightful chance,
No more the input's hasty, rushing leap—
Let marked text finish ere the codes run deep! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and specifically describes the main change: fixing Ctrl+H behavior during IME input to delete composing text instead of committed text, which directly matches the code change that adds hasMarkedText() guarding.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 1 file

greptile-apps · 2026-03-03T09:33:32Z

Greptile Summary

Fixes Ctrl+H incorrectly deleting committed text instead of composing text during IME input by adding a hasMarkedText() guard to the Ctrl key fast path. The fix ensures that when IME composition is active (e.g., Japanese hiragana input), Ctrl-modified keys are routed through interpretKeyEvents() instead of bypassing to Ghostty directly.

Added && !hasMarkedText() condition to line 3014 in the Ctrl fast path
Matches existing IME handling patterns in the codebase (see performKeyEquivalent bypasses)
Minimal, surgical fix that only affects the specific fast path during composition
Well-supported by existing test infrastructure in CJKIMEInputTests.swift

Confidence Score: 5/5

This PR is safe to merge with minimal risk
One-line fix that adds a well-tested guard condition to existing fast path logic. The hasMarkedText() method is extensively used throughout the codebase with comprehensive test coverage. The fix is minimal, focused, and follows established patterns for IME handling.
No files require special attention

Important Files Changed

Filename	Overview
Sources/GhosttyTerminalView.swift	Added `hasMarkedText()` guard to Ctrl key fast path to properly handle IME composition - minimal, focused fix for Ctrl+H during Japanese/CJK input

_{Last reviewed commit: 132bc6c}

lawrencecchen · 2026-03-03T23:54:25Z

@codex review

chatgpt-codex-connector · 2026-03-03T23:56:42Z

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

atani · 2026-03-05T06:47:08Z

As a Japanese IME user, this is a fix I've been wanting. Ctrl+H deleting committed text during composition has been a real pain point. Looking forward to seeing this merged.

During IME composition (e.g. Japanese input), Ctrl+H should delete composing characters via the IME, not bypass it and send a backspace directly to the terminal. Add a hasMarkedText() check so the fast path is only taken when no IME composition is active, letting interpretKeyEvents() handle the key instead. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

cubic-dev-ai Bot reviewed Mar 3, 2026

View reviewed changes

lawrencecchen merged commit bf28f5d into manaflow-ai:main Mar 5, 2026
10 of 11 checks passed

0xble added a commit to 0xble/cmux that referenced this pull request Mar 7, 2026

Skip Ctrl fast path during IME composition (manaflow-ai#790)

6db9483

coderabbitai Bot mentioned this pull request Mar 10, 2026

Add os_log diagnostics for IME + resize freeze #1151

Closed

3 tasks

This was referenced Apr 13, 2026

Fix macOS modifier desync causing idle terminal input corruption #2855

Merged

Fix modifier press/release suppressed during IME marked text #2953

Open

coderabbitai Bot mentioned this pull request Apr 23, 2026

Fix terminal rendering lag during key repeat #3131

Closed

1 of 6 tasks

This was referenced May 5, 2026

fix: deduplicate numpad input across IME full-to-half-width transition (#3284) #3292

Merged

Restore Zhuyin IME candidate marked-text handling #3574

Merged

Fix arrow key navigation in IME candidate window during composition #3694

Merged

This was referenced May 11, 2026

Fix Zhuyin candidate-window arrow navigation (#3691), with guardrails #3850

Closed

Fix browser omnibar IME candidate window for Japanese / Zhuyin #4268

Merged

austinywang mentioned this pull request Jun 13, 2026

Ctrl+H deletes confirmed characters instead of pre-edit text when using Japanese IME #787

Closed

ShotaNagafuchi mentioned this pull request Sep 21, 2026

Japanese IME: Backspace during conversion clears the entire pre-edit text #13416

Closed

Navigation Menu

Uh oh!

Fix Ctrl+H deleting committed text instead of composing text during IME input - #790

Fix Ctrl+H deleting committed text instead of composing text during IME input#790
lawrencecchen merged 1 commit into
manaflow-ai:mainfrom
sminamot:fix/ime-ctrl-backspace

sminamot commented Mar 3, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Mar 3, 2026

Uh oh!

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

cubic-dev-ai Bot left a comment

Uh oh!

greptile-apps Bot commented Mar 3, 2026

Uh oh!

lawrencecchen commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 3, 2026

Uh oh!

atani commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sminamot commented Mar 3, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Test plan

Summary by cubic

Summary by CodeRabbit

Uh oh!

vercel Bot commented Mar 3, 2026

Uh oh!

coderabbitai Bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Mar 3, 2026

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

lawrencecchen commented Mar 3, 2026

Uh oh!

chatgpt-codex-connector Bot commented Mar 3, 2026

Uh oh!

atani commented Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sminamot commented Mar 3, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 3, 2026 •

edited

Loading