Fix AZERTY Option+Delete word delete in Claude Code - #1639
austinywang wants to merge 1 commit into
Conversation
|
@austinywang is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes refine key event text extraction and control character handling in the terminal view. A new helper function validates control characters, text-sending logic filters derived text through Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Superseded by #1640, which uses the branch on manaflow-ai/cmux instead of the fork branch. |
Summary
Option+Delete) as a non-text control key in the terminal key bridgeOption+Deletethrough the realkeyDownpathCloses #1635.
Verification
./scripts/reload.sh --tag fix-1635-azerty-deleteSummary by cubic
Fixes Option+Delete on AZERTY by treating Delete (DEL) as a non-text key and not consuming Option, so Alt+Delete deletes a word again in the terminal. Adds a regression test that drives a synthetic Option+Delete through keyDown to ensure Alt is preserved and no DEL text is sent.
Written for commit e9db155. Summary will update on new commits.
Summary by CodeRabbit
Bug Fixes
Tests