Repository navigation
Conversation
|
@iammmiru is attempting to deploy a commit to the Manaflow Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the synchronous Confidence Score: 5/5Safe to merge — small, targeted removal of a synchronous call that was causing key-repeat lag, consistent with documented project policy. All changes are deletions of code that was explicitly discouraged by the project's own CLAUDE.md pitfalls section. No new logic is introduced, no correctness regression is present, and the rendering path continues to be driven by Ghostty's existing wakeup/tick mechanism. No P0 or P1 findings. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant AppKit
participant GhosttyNSView
participant GhosttyCore
participant Renderer
User->>AppKit: Key press / key repeat
AppKit->>GhosttyNSView: keyDown(with:)
GhosttyNSView->>GhosttyCore: ghostty_surface_key()
Note over GhosttyNSView: BEFORE: forceRefresh() called synchronously here on every text input
GhosttyCore-->>Renderer: schedules wakeup/tick
Renderer-->>User: frame rendered
Note over GhosttyNSView: AFTER: returns immediately, renderer drives display via Ghostty wakeups
Reviews (1): Last reviewed commit: "fix: avoid sync refresh on repeated text..." | Re-trigger Greptile |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
You’re at about 90% of the monthly review limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
|
do your changes fix this issue for you? |
|
Yes cmux feels very responsive and snappy now |
|
dang this needs to get merged in |
|
It looks like #3986 duplicates this + plus adds a test to confirm no rendering regressions are added; should we combine the two branches? |
|
Thanks for this! The key-repeat lag fix landed on main in #3986. You opened this first, so you got there first. Closing since main covers it now. |
4 participants
Summary
Hi! I'm really enjoying using cmux — thanks for building it.
I ran into the key-repeat lag described in #1829 and dug into it a bit.
terminalSurface?.forceRefresh(reason: "keyDown.textInput")call fromGhosttyNSView.keyDown(with:).Testing
hjklDemo Video
For UI or behavior changes, include a short demo video (GitHub upload, Loom, or other direct link).
Review Trigger (Copy/Paste as PR comment)
Checklist
Summary by CodeRabbit
Summary by cubic
Fixes render lag during key repeat by removing a synchronous
terminalSurface?.forceRefreshin the text-input path. Rendering now stays smooth under sustained input and relies on Ghostty’s normal wakeup/tick cycle.forceRefresh(reason: "keyDown.textInput")fromGhosttyNSView.keyDown(with:)to avoid main-thread stalls during key repeat.refreshMsfrom debug timing logs.Written for commit 7b9b748. Summary will update on new commits.