Repository navigation
base red: the message-row chevron test measures the gap after the preview, not the sender - #35851
Merged
Merged
Conversation
…view, not the sender #34464 put the sender and the first line on one row again, so the line holds both .cv-received__from and .cv-received__preview. querySelector with the list ".cv-received__preview, .cv-received__from" returns the earlier node in the document, the sender, and the test read the gap from the sender's name to the chevron (233-275 px) instead of from the words (under 8.5 px). It now takes the preview first and falls back to the sender in the stacked look. Red on the base, green here: cd webviews && CMUX_BROWSER_TESTS=1 bun test ./test/incoming-message-disclosure-browser.test.ts -t "a delivered message and a waiting one" Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Session: https://cmux.com/deeplink/agent?id=aid-8707001042ea634e8771
Contributor
|
cmux status (one comment, edited in place; each line is updated by the job that owns it) Review App of this head (app.zip, kept 1 day)
Shipped in:
|
Collaborator
Author
|
Owned by an agent session · session |
teamleaderleo
temporarily deployed
to
ci-routing-agent
November 4, 2026 19:52 — with
GitHub Actions
Inactive
Collaborator
Author
This was referenced Nov 4, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incoming-message-disclosure-browser.test.ts > a delivered message and a waiting one draw the same line: chevron after the words, actions on hoverhas been red on every feat-cmux-next push since #34464 (13 of 13 push runs in the last day,Expected: <= 8.5 / Received: 265.7at line 477).Cause
#34464 puts the sender and the message's first line on one row again, so the line holds both
.cv-received__fromand.cv-received__preview.querySelector(".cv-received__preview, .cv-received__from")returns whichever node comes first in the document, which is the sender. The test then measured the gap from the sender's name to the chevron (233-275 px) instead of from the message's words. The UI is right: the chevron sits right after the preview.Change
The test now measures from the preview and falls back to the sender only in the stacked gallery look. This is a test-only change.
Verification
cd webviews && CMUX_BROWSER_TESTS=1 bun test ./test/incoming-message-disclosure-browser.test.ts -t "a delivered message and a waiting one": red on the base (0 pass, 1 fail), green here (1 pass).Observed / Not run
the chat's last row, opened with the view at its end, ...; closed, stays on its pixel. It started with Agent transcript: tool calls animate open and closed again; at the bottom the text above glides up as one stack #34780: after the bottom fold, a programmatic scroll (scrollIntoViewIfNeeded, or settingscrollTop) is pulled back to the end within 300 ms, so the line stays at -922 px. That is a change in the transcript's follow behaviour, not a test bug, and it goes to Agent transcript: tool calls animate open and closed again; at the bottom the text above glides up as one stack #34780's owner.Changelog
none
Agent session: agent session
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Fixes the message-row chevron test, which has been red on every feat-cmux-next push since #34464.
#34464 put the sender and the message's first line back on one row, so the test's list selector returned the sender (the earlier node in the document) and measured the gap from the sender's name to the chevron (233–275 px) instead of from the words. The test now queries the preview first and falls back to the sender only in the stacked gallery look. Test-only change.
The file's other red test (
the chat's last row, opened with the view at its end, ...) is not fixed here: it started with #34780 and is a change in the transcript's follow behaviour, not a test bug.Written for commit 9239b3c. Summary will update on new commits.