Skip to content

base red: the message-row chevron test measures the gap after the preview, not the sender - #35851

Merged
teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fm3h/imd-chevron-gap-preview
Nov 4, 2026
Merged

teamleaderleo merged 1 commit into
feat-cmux-nextfrom
fm3h/imd-chevron-gap-preview

Conversation

@teamleaderleo

@teamleaderleo teamleaderleo commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

incoming-message-disclosure-browser.test.ts > a delivered message and a waiting one draw the same line: chevron after the words, actions on hover has been red on every feat-cmux-next push since #34464 (13 of 13 push runs in the last day, Expected: <= 8.5 / Received: 265.7 at line 477).

Cause

#34464 puts the sender and the message's first line on one row again, so the line holds both .cv-received__from and .cv-received__preview. querySelector(".cv-received__preview, .cv-received__from") returns whichever node comes first in the document, which is the sender. The test then measured the gap from the sender's name to the chevron (233-275 px) instead of from the message's words. The UI is right: the chevron sits right after the preview.

Change

The test now measures from the preview and falls back to the sender only in the stacked gallery look. This is a test-only change.

Verification

cd webviews && CMUX_BROWSER_TESTS=1 bun test ./test/incoming-message-disclosure-browser.test.ts -t "a delivered message and a waiting one": red on the base (0 pass, 1 fail), green here (1 pass).

Observed / Not run

Changelog

none

Agent session: agent session

🤖 Generated with Claude Code


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.


Summary by cubic

Fixes the message-row chevron test, which has been red on every feat-cmux-next push since #34464.

#34464 put the sender and the message's first line back on one row, so the test's list selector returned the sender (the earlier node in the document) and measured the gap from the sender's name to the chevron (233–275 px) instead of from the words. The test now queries the preview first and falls back to the sender only in the stacked gallery look. Test-only change.

The file's other red test (the chat's last row, opened with the view at its end, ...) is not fixed here: it started with #34780 and is a change in the transcript's follow behaviour, not a test bug.

Written for commit 9239b3c. Summary will update on new commits.

View guided diff Turn on auto-fix

…view, not the sender

#34464 put the sender and the first line on one row again, so the line holds both
.cv-received__from and .cv-received__preview. querySelector with the list
".cv-received__preview, .cv-received__from" returns the earlier node in the
document, the sender, and the test read the gap from the sender's name to the
chevron (233-275 px) instead of from the words (under 8.5 px). It now takes
the preview first and falls back to the sender in the stacked look.

Red on the base, green here:
cd webviews && CMUX_BROWSER_TESTS=1 bun test ./test/incoming-message-disclosure-browser.test.ts -t "a delivered message and a waiting one"

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Agent-Session: https://cmux.com/deeplink/agent?id=aid-8707001042ea634e8771
@teamleaderleo teamleaderleo added the risk:low Risk tier (docs/ci/risk-tiers.md) label Nov 4, 2026
@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

cmux status (one comment, edited in place; each line is updated by the job that owns it)

Review 9239b3c: HQ feed card · gallery before/after runs · checks

App of this head (app.zip, kept 1 day)

gh workflow run reload-build.yml -R manaflow-ai/cmux --ref feat-cmux-next -f tag=pr35851 -f ref=fm3h/imd-chevron-gap-preview -f platform=macos -f backend_mode=local

Shipped in:

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Owned by an agent session · session

@teamleaderleo

Copy link
Copy Markdown
Collaborator Author

Review (codex, router-review): SHIP at 9239b3c

Reviewer: codex gpt-6.1-sol xhigh, fast tier.

SHIP at 9239b3c

Visual verdict: no images; Leo tries the build

Follow-ups: none

@cmux-bot cmux-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmux-bot approves 9239b3c: an independent review passed this exact head (router-review receipt by teamleaderleo). A push needs a new review; a later BLOCK at this head dismisses this approval.

@teamleaderleo
teamleaderleo merged commit e01bbae into feat-cmux-next Nov 4, 2026
216 of 226 checks passed
@teamleaderleo
teamleaderleo deleted the fm3h/imd-chevron-gap-preview branch November 4, 2026 20:50

This branch was previously deployed

1 inactive deployment
ci-routing-agent — 9239b3cd Deployed Nov 4, 2026 by teamleaderleo via wait for same-key tree publisher #112920
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:low Risk tier (docs/ci/risk-tiers.md)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant