Skip to content

base red: the message-row chevron test measures the gap after the preview, not the sender #35851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teamleaderleo merged 1 commit into from
Nov 4, 2026
Merged

base red: the message-row chevron test measures the gap after the preview, not the sender #35851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions webviews/test/incoming-message-disclosure-browser.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,12 @@ await requireBrowserLane("incoming-message-disclosure-browser.test.ts", async ()
const line = row.querySelector<HTMLElement>(":scope > .cv-disclosure__line")!;
const chevron = line.querySelector<HTMLElement>(".cv-rotor")!.getBoundingClientRect();
// The line's last words: its first line's, or the sender's (its text, not its padded box) in
// the stacked gallery look.
// the stacked gallery look. The preview first: in the default one-line look (#34464) the
// sender comes before it on the same line, and a list selector returns the earlier node.
const range = document.createRange();
range.selectNodeContents(line.querySelector(".cv-received__preview, .cv-received__from")!);
range.selectNodeContents(
line.querySelector(".cv-received__preview") ?? line.querySelector(".cv-received__from")!,
);
const words = range.getBoundingClientRect();
const hover = line.querySelector<HTMLElement>(".cv-received__hover");
return {
Expand Down
Loading